refactor(api): move repo logic to separate package#754
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #754 +/- ##
==========================================
+ Coverage 54.87% 56.89% +2.02%
==========================================
Files 244 243 -1
Lines 16506 15939 -567
==========================================
+ Hits 9058 9069 +11
+ Misses 7048 6468 -580
- Partials 400 402 +2
|
cognifloyd
previously approved these changes
Mar 9, 2023
Member
cognifloyd
left a comment
There was a problem hiding this comment.
One minor nit, but looks good to me anyway. It's nice to see all of this moving into separate modules with shorter files. So much nicer.
cognifloyd
previously approved these changes
Mar 10, 2023
ecrupper
previously approved these changes
Mar 15, 2023
Contributor
ecrupper
left a comment
There was a problem hiding this comment.
A couple questions out of curiosity, but otherwise LGTM — I like the refactor
Contributor
Author
|
@cognifloyd @ecrupper ready for review again 👍 |
cognifloyd
approved these changes
Mar 16, 2023
ecrupper
approved these changes
Mar 21, 2023
This was referenced Apr 22, 2023
This was referenced May 17, 2023
This was referenced May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of #615
This change continues the refactor efforts initially introduced in the above PR.
This adds a new
repopackage to thegithub.com/go-vela/server/apipackage.This contains all the same handlers that existed previously but with each of them within their own file.
Also, this change skips checking a user's access for orgs, repos, and teams if that resource is in their personal org.
i.e. Vela no longer check's my access level for those resources when interacting with https://github.com/jbrockopp
This will help improve the user experience when developing locally and reduce unneeded calls to the SCM.