refactor(api): move log logic into separate package#855
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #855 +/- ##
==========================================
+ Coverage 63.10% 64.84% +1.73%
==========================================
Files 285 284 -1
Lines 14944 14543 -401
==========================================
Hits 9430 9430
+ Misses 5068 4667 -401
Partials 446 446 |
cognifloyd
requested changes
May 20, 2023
cognifloyd
reviewed
May 20, 2023
cognifloyd
reviewed
May 20, 2023
cognifloyd
approved these changes
May 22, 2023
plyr4
approved these changes
May 22, 2023
This was referenced May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off of #615 #754 #809 #828 #829 #847 #848 #849 #851 and #853
This change continues the refactor efforts initially introduced in the above PRs.
This adds a new
logpackage to thegithub.com/go-vela/server/apipackage.This contains all the same handlers that existed previously but with each of them within their own file.
Also changed
GetBuildLogstoListLogsForBuildto stay consistent.