Revert the changes from PR #1044 and #1045 and standardize on Object ** encoding in ptrcall

[dsnopek]

This is draft because I don't necessarily know that this is what we want to do yet.

See the discussion on issue #1119

When this is paired with a PR godotengine/godot#77410 to Godot that implements "possible solution nr 2", then both virtual and non-virtual methods are called with a consistent encoding (ie. Object **) and seem to work in my limited testing :-)

NOTE: This should fail tests until godotengine/godot#77410 is merged (if it is merged)

[saki7]

We need tests for this issue (#1045 (comment))

• Callee is non-virtual / virtual
• Parameter is Object* / Ref<T> / Scalar
• Parameter qualifier is Value / const Value&
• Return type is void / Object* / Ref<T> / Scalar

Total: 2 * 3 * 2 * 4 = 48 cases

I think we should merge your PR #1101 asap.

[dsnopek]

I've updated the tests so that they fail due to the regressions from #1044 and #1045. (So, this failure is a success!)

Also, the tests seemed to have stopped failing on the bugs that #1044 and #1045 originally set out to fix! It looks like we were no longer getting a ptrcall in the situation we needed to, so I also swapped out the $Example for a var example: Example = $Example variable which got that correctly tested again as well.

The tests do pass when paired with the Godot PR godotengine/godot#77410

[Daylily-Zeleen]

The crash happen at overried EditorInspectorPlugin::_can_handles(Object * object), is it relate about this?

[dsnopek]

The crash happen at overried EditorInspectorPlugin::_can_handles(Object * object), is it relate about this?

Yes. If you use this PR together with Godot PR godotengine/godot#77410 then that crash won't happen. In a personal project I have a working EditorPlugin from GDExtension using these :-)

[dsnopek]

Now that Godot PR godotengine/godot#77410 has been merged, I've rebased this and taken it out of draft.

The CI should pass now that the Godot changes are in and a new artifact has been created. If not, I'd like to get that fixed before merging this one.

[akien-mga]

LGTM, TIWAGOS ;)

[akien-mga]

Thanks!