Use different Object/Ref encoding for virtual methods#1135
Closed
dsnopek wants to merge 1 commit intogodotengine:masterfrom
Closed
Use different Object/Ref encoding for virtual methods#1135dsnopek wants to merge 1 commit intogodotengine:masterfrom
dsnopek wants to merge 1 commit intogodotengine:masterfrom
Conversation
991f044 to
1d658b6
Compare
1d658b6 to
adfc303
Compare
Contributor
|
Thanks for illustrating this solution. IMHO this approach (option nr 3) should be avoided at all costs because it seems to require a lot of ad-hoc differentiations. Even though we have those helpful Quoting from #1119 (comment):
Few hours ago godotengine/godot#77410 has received an approval. We should choose that one alongside with #1123. |
Collaborator
Author
|
Superceded by PR #1123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to implement option nr 3 from issue #1119
Basically, it just decodes objects from
Object **in virtual methods, and fromObject *in all other situations.There shouldn't affect performance - basically
PtrToArg<>::convert()expands to different code when used for a virtual vs non-virtual method.(It's an alternative to #1123 which is implementing option nr 2)