{cmake} FLOAT_PRECISION should be GODOT_FLOAT_PRECISION & added to the target#1145
Closed
asmaloney wants to merge 1 commit intogodotengine:masterfrom
Closed
{cmake} FLOAT_PRECISION should be GODOT_FLOAT_PRECISION & added to the target#1145asmaloney wants to merge 1 commit intogodotengine:masterfrom
asmaloney wants to merge 1 commit intogodotengine:masterfrom
Conversation
asmaloney
force-pushed
the
cmake-precision
branch
from
6e91dda to
c1b9587
Compare
asmaloney
changed the title
asmaloney
force-pushed
the
cmake-precision
branch
from
c1b9587 to
f7eb931
Compare
…e target All top-level CMake options should be prefixed with GODOT_ so as not to "pollute the environment" when included in other projects. Adding it to the target as PUBLIC will propagate it to any projects including godot-cpp.
asmaloney
force-pushed
the
cmake-precision
branch
from
f7eb931 to
0e4fe86
Compare
Contributor
Author
|
bump |
Member
|
@asmaloney Can you rebase the git pull request? |
fire
approved these changes
Jun 30, 2024
Member
fire
left a comment
fire
left a comment
There was a problem hiding this comment.
The general flow looks good to me, but needs a rebase.
aaronfranke
reviewed
Sep 18, 2024
Member
aaronfranke
left a comment
aaronfranke
left a comment
There was a problem hiding this comment.
The rename part of this PR has been superseded by PR #1583.
Comment on lines
+163
to
+167
| if("${GODOT_FLOAT_PRECISION}" STREQUAL "double") | ||
| target_compile_definitions( ${PROJECT_NAME} PUBLIC | ||
| REAL_T_IS_DOUBLE | ||
| ) | ||
| endif() |
Member
There was a problem hiding this comment.
Is this needed anymore now that we have this code?
set(GODOT_PRECISION "single" CACHE STRING "Set the floating-point precision level (single|double)")
if ("${GODOT_PRECISION}" STREQUAL "double")
add_definitions(-DREAL_T_IS_DOUBLE)
endif()
Collaborator
There was a problem hiding this comment.
I think you're right, this is no longer needed
Collaborator
|
Thanks! However, it looks like this was fixed by another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All top-level CMake options should be prefixed with GODOT_ so as not to "pollute the environment" when included in other projects.
Adding it to the target as
PUBLICwill propagate it to any projects including godot-cpp.