[SCons] Add support to import custom variables from parent SConstruct#1196
Closed
adamscott wants to merge 1 commit intogodotengine:masterfrom
Closed
[SCons] Add support to import custom variables from parent SConstruct#1196adamscott wants to merge 1 commit intogodotengine:masterfrom
adamscott wants to merge 1 commit intogodotengine:masterfrom
Conversation
6b3a1bc to
a1af1e8
Compare
Collaborator
|
Thanks! However, since the parent SConstruct can already pass in it's own This seems to overlap with what was added in PR #1170 |
This was referenced Aug 16, 2023
Member
Author
|
Closing that PR, will do another one. |
Member
Author
I tested out and it doesn't work. What custom.py sets up is variables to be picked up by So, when we are passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes parent SConstruct able to apply their
custom.pyvalues to the main SConstruct file.Otherwise, even if the parent SConstruct has
use_llvm = True, the main SConstruct file will ignore it unless you manually adduse_llvm=yesin the command line.