Add support to import custom variables from parent SConstruct (redux)#1220
Merged
dsnopek merged 1 commit intogodotengine:masterfrom Sep 21, 2023
Merged
Conversation
adamscott
added
enhancement
adamscott
force-pushed
the
add-local-custom-support-redux
branch
from
34ff52b to
982e01e
Compare
dsnopek
approved these changes
Sep 21, 2023
Collaborator
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Discussed at the GDExtension meeting, and we think this looks good!
Collaborator
|
Cherry-picked for 4.1 in PR #1261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version of #1196.
As explained here, the
envpassed from the parent SConstruct don't have the values from the custom files. So, in order to the custom files to be loaded in the godot-cpp project from the parent, it is essential to pass the "customs" variable.