Refactor compiledb implementation#1230
Merged
dsnopek merged 1 commit intogodotengine:masterfrom Oct 19, 2023
Merged
Conversation
adamscott
added
topic:buildsystem
adamscott
force-pushed
the
compiledb-alias
branch
from
6c5b6af to
7d7a085
Compare
nlupugla
reviewed
Sep 9, 2023
nlupugla
left a comment
nlupugla
left a comment
There was a problem hiding this comment.
Tested on my build and it works great!
Collaborator
|
Discussed at the GDExtension meeting, and we think this makes sense! But we're going to save this one to discuss again later, when we plan to have a special meeting to tackle a lot of build system issues at once. |
Faless
reviewed
Oct 18, 2023
Contributor
|
Not sure if anyone else has this experience, but this PR has been the only way I've gotten |
adamscott
force-pushed
the
compiledb-alias
branch
from
7d7a085 to
68570d6
Compare
This comment enables the possibility to build the "compile_commands.json" file by only using `scons -Q compiledb`. No need to use the argument `compiledb=yes`. And when using the `compiledb=yes`, it will create a "compiled_commands.json" automatically.
adamscott
force-pushed
the
compiledb-alias
branch
from
68570d6 to
2d5024a
Compare
Member
Author
|
I implemented @Faless' suggestion. |
Collaborator
|
Cherry-picked for 4.1 in PR #1281 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comment enables the possibility to build the "compile_commands.json" file by only using
scons -Q compiledb. No need to use the argumentcompiledb=yes.And when using the
compiledb=yes, it will create a "compiled_commands.json" automatically.