Skip to content

Conversation

@Flux159
Copy link
Contributor

@Flux159 Flux159 commented Jul 28, 2020

Note that windows & HTML5 exporter builds are currently broken due to quickjs_debugger not being supported on those platforms (sys/socket.h error).

The workflow currently takes this into account by checking out a working commit with "git checkout 01bc02" - this should probably be fixed on master though.

See https://github.com/Flux159/ECMAScript/actions/runs/185203742 for build artifacts produced for Linux, Windows, Mac, and HTML5

See #36

Copy link
Collaborator

@Geequlim Geequlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
Please squash the commits

parent 63197a2
author Flux159 <flux159@gmail.com> 1596297307 -0500
committer Flux159 <flux159@gmail.com> 1596298951 -0500

parent 63197a2
author Flux159 <flux159@gmail.com> 1596297307 -0500
committer Flux159 <flux159@gmail.com> 1596298547 -0500

Adding github workflow for automated builds.

Adding github workflow for automated builds.

Seeing how to run on container.

Seeing if container is running.

Using docker package in github registry.

Fixing yaml error.

Adding html5 job, attempting to fix windows build, and trying to use publish artifact action.

More fixes for windows & html5 builds.

More fixes for windows & html5

Still working on fixing up windows & html5 builds.

More fixes for html5.

Fixing code review comments.
@Flux159 Flux159 requested a review from Geequlim August 1, 2020 16:30
Copy link
Collaborator

@Geequlim Geequlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Geequlim Geequlim merged commit d3ce0c7 into godotjs:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants