Docs/jsx code completion #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the Typescript section to also reference JSX code completion, with instructions on how to add the definitions .ts file to the package.json for JSX code completion support.
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issue #73, I have made 2 simple QOL changes:
READMEwith some simple pointers on how to get JSX code completion working in the TypeScript section.misc/package.jsonto include"types": "godot.d.ts"by default so that JSX completion should work immediately when generating a TypeScript project from the editor.I think it might also be nice to be able to generate the
decorators.ts/jsfile separately alongside the existing options to generate the declaration file and enumerations file separately, in case someone didn't want to generate a full TypeScript project but did want to use the decorators. However my C++ is very rusty and my attempt at this didn't get very far, apologies :)