Update persistence state to track counts of messages instead of times banner has been displayed by Adib234 · Pull Request #13428 · google-gemini/gemini-cli

Adib234 · 2025-11-19T18:26:09Z

Summary

We would like to keep track of counts by the number of times a message has shown and not just how many times the banner has been shown.

Details

Related Issues

How to Validate

Manually validated by changing default text on debug settings.

Pre-Merge Checklist

gemini-code-assist · 2025-11-19T18:26:29Z

Summary of Changes

Hello @Adib234, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the banner display logic to enable more precise tracking of how often specific messages are shown to users. Instead of a single counter for a default banner, the system now maintains a map of banner messages to their individual display counts, allowing for better control and analytics over banner visibility.

Highlights

Refactored Banner Count Persistence: The system now tracks the display count for individual banner messages using a map (bannerCounts) instead of a single counter (defaultBannerShownCount).
Granular Message Tracking: This change allows for tracking how many times each specific banner message has been shown, rather than just a generic default banner.
Updated UI Logic: The AppHeader component has been updated to read and update these new message-specific counts, ensuring banners are displayed correctly based on their individual history.
Test Suite Alignment: Corresponding test cases in AppHeader.test.tsx have been adjusted to reflect the new persistence mechanism.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors the banner display logic to track view counts for each unique banner message, instead of a single global count. This is a great improvement for more granular control over banner visibility.

However, I've identified a critical issue in the implementation within AppHeader.tsx. The component's state for bannerCounts is not updated after being incremented, causing the banner to be displayed indefinitely regardless of the view count. I've provided a detailed comment and a code suggestion to fix this.

Additionally, a test case in packages/cli/src/ui/components/AppHeader.test.tsx seems to have been missed during the refactoring. The test 'should not render the default banner if shown count is 5 or more' (line 129) still uses the old data structure for mocking persistentState.get(), which will cause the test to fail. This should be updated to align with the new bannerCounts object structure.

llu77 · 2025-11-19T18:32:47Z

Ok

github-actions · 2025-11-19T18:33:16Z

Size Change: +956 B (0%)

Total Size: 21.1 MB

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/gemini.js`	21.1 MB	+956 B (0%)
`./bundle/sandbox-macos-permissive-closed.sb`	1.03 kB	0 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-closed.sb`	3.29 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B

_{compressed-size-action}

… to hook, add tests for hook

…essages instead of times banner has been displayed (google-gemini#13428)

… banner has been displayed (google-gemini#13428)

Adib234 · 2025-11-24T16:54:50Z

/patch stable

github-actions · 2025-11-24T16:55:06Z

✅ Patch workflow(s) dispatched successfully!

📋 Details:

Channels: stable
Commit: 3e50be1658a8f2be9c913211cb945aeb38a112d5
Workflows Created: 1

🔗 Track Progress:

… banner has been displayed (#13428) # Conflicts: # packages/cli/src/ui/components/AppHeader.tsx

github-actions · 2025-11-24T20:00:07Z

🚀 Patch PR Created!

📋 Patch Details:

Environment: prod
Channel: stable → will publish to npm tag latest
Commit: 3e50be1658a8f2be9c913211cb945aeb38a112d5
Hotfix Branch: hotfix/v0.17.1/0.17.2/stable/cherry-pick-3e50be1/pr-13428
Hotfix PR: #13760
⚠️ Status: Cherry-pick conflicts detected - manual resolution required

📝 Next Steps:

⚠️ Resolve conflicts in the hotfix PR first: #13760
Test your changes after resolving conflicts
Once merged, the patch release will automatically trigger
You'll receive updates here when the release completes

🔗 Track Progress:

View hotfix PR #13760

… banner has been displayed (#13428)

Adib234 · 2025-11-25T18:53:17Z

/patch preview

github-actions · 2025-11-25T18:53:35Z

✅ Patch workflow(s) dispatched successfully!

📋 Details:

Channels: preview
Commit: 3e50be1658a8f2be9c913211cb945aeb38a112d5
Workflows Created: 1

🔗 Track Progress:

… banner has been displayed (#13428)

github-actions · 2025-11-25T18:59:52Z

🚀 Patch PR Created!

📋 Patch Details:

Environment: prod
Channel: preview → will publish to npm tag preview
Commit: 3e50be1658a8f2be9c913211cb945aeb38a112d5
Hotfix Branch: hotfix/v0.18.0-preview.2/0.18.0-preview.3/preview/cherry-pick-3e50be1/pr-13428
Hotfix PR: #13821

📝 Next Steps:

Review and approve the hotfix PR: #13821
Once merged, the patch release will automatically trigger
You'll receive updates here when the release completes

🔗 Track Progress:

View hotfix PR #13821

github-actions · 2025-11-25T19:11:47Z

🚀 Patch Release Started!

📋 Release Details:

Environment: prod
Channel: preview → publishing to npm tag preview
Version: v0.18.0-preview.2
Hotfix PR: Merged ✅
Release Branch: release/v0.18.0-preview.2-pr-13428

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

View release workflow

github-actions · 2025-11-25T19:37:05Z

✅ Patch Release Complete!

📦 Release Details:

Version: 0.18.0-preview.3
NPM Tag: preview
Channel: preview
Dry Run: false

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

GitHub Release: View release v0.18.0-preview.3
NPM Package: npm install @google/gemini-cli@preview

🔗 Links:

… banner has been displayed (google-gemini#13428)

complete

bbf5a4f

Adib234 requested a review from sehoon38 November 19, 2025 18:26

Adib234 self-assigned this Nov 19, 2025

Adib234 requested a review from a team as a code owner November 19, 2025 18:26

restore comments

31b2b9d

gemini-code-assist Bot reviewed Nov 19, 2025

View reviewed changes

Comment thread packages/cli/src/ui/components/AppHeader.tsx Outdated

Adib234 added 3 commits November 19, 2025 15:42

update to new structure of data structure and impl

af22f80

change impl to include customized banner shown counts, refactor logic…

df2f59d

… to hook, add tests for hook

fix test

eaa0696

sehoon38 reviewed Nov 20, 2025

View reviewed changes

Comment thread packages/cli/src/ui/hooks/useBanner.ts Outdated

sehoon38 reviewed Nov 20, 2025

View reviewed changes

Comment thread packages/cli/src/ui/hooks/useBanner.ts Outdated

sehoon38 approved these changes Nov 20, 2025

View reviewed changes

fix test and address nit

1785bd4

Adib234 force-pushed the adibakm/update-persistence-state branch from b11bda3 to 1785bd4 Compare November 20, 2025 20:57

Adib234 and others added 3 commits November 20, 2025 13:02

Merge branch 'main' into adibakm/update-persistence-state

7d590ee

merge

2315822

map hashed string to count

908a9ad

Adib234 added this pull request to the merge queue Nov 20, 2025

sehoon38 approved these changes Nov 20, 2025

View reviewed changes

Merged via the queue into main with commit 3e50be1 Nov 20, 2025
22 checks passed

Adib234 deleted the adibakm/update-persistence-state branch November 20, 2025 22:15

thacio added a commit to thacio/auditaria that referenced this pull request Nov 23, 2025

Merge Commit '3e50be1': Update persistence state to track counts of m…

38f1441

…essages instead of times banner has been displayed (google-gemini#13428)

werdnum pushed a commit to werdnum/gemini-cli that referenced this pull request Nov 24, 2025

Update persistence state to track counts of messages instead of times…

932ab07

… banner has been displayed (google-gemini#13428)

werdnum mentioned this pull request Nov 24, 2025

feat(ui): Show waiting MCP servers in ConfigInitDisplay #13721

Merged

18 tasks

github-actions Bot pushed a commit that referenced this pull request Nov 24, 2025

Update persistence state to track counts of messages instead of times…

6279258

… banner has been displayed (#13428) # Conflicts: # packages/cli/src/ui/components/AppHeader.tsx

mboshernitsan pushed a commit that referenced this pull request Nov 25, 2025

Update persistence state to track counts of messages instead of times…

5447a62

… banner has been displayed (#13428)

github-actions Bot pushed a commit that referenced this pull request Nov 25, 2025

Update persistence state to track counts of messages instead of times…

2ac452c

… banner has been displayed (#13428)

danpalmer pushed a commit to danpalmer/gemini-cli that referenced this pull request Nov 29, 2025

Update persistence state to track counts of messages instead of times…

d032b4e

… banner has been displayed (google-gemini#13428)

Conversation

Adib234 commented Nov 19, 2025

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

Uh oh!

gemini-code-assist Bot commented Nov 19, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

llu77 commented Nov 19, 2025

Uh oh!

github-actions Bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Adib234 commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

Adib234 commented Nov 25, 2025

Uh oh!

github-actions Bot commented Nov 25, 2025

Uh oh!

github-actions Bot commented Nov 25, 2025

Uh oh!

github-actions Bot commented Nov 25, 2025

Uh oh!

github-actions Bot commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Nov 19, 2025 •

edited

Loading