fix(patch): cherry-pick 3e50be1 to release/v0.17.1-pr-13428 [CONFLICTS]#13760
Conversation
… banner has been displayed (#13428) # Conflicts: # packages/cli/src/ui/components/AppHeader.tsx
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, an automated cherry-pick, updates the CLI's banner display mechanism. It introduces a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a cherry-pick that updates how banner display counts are persisted, moving from a single count to a per-message count using a hash of the message text. This logic is encapsulated in a new useBanner hook. The review has identified several critical issues. The AppHeader.tsx component contains unresolved merge conflicts which will prevent the code from compiling. Additionally, the new useBanner hook does not handle the legacy format of the persisted banner count, which will lead to a runtime crash. These issues must be addressed.
|
Size Change: +846 B (0%) Total Size: 20.6 MB ℹ️ View Unchanged
|
This PR automatically cherry-picks commit 3e50be1 to patch version v0.17.1 in the stable release to create version 0.17.2.
This cherry-pick resulted in merge conflicts that need manual resolution.
🔧 Next Steps:
📋 Files with conflicts:
The commit has been created with conflict markers for easier manual resolution.
🚨 Important: