Change default compress threshold to 0.5 for api key users#13517
Change default compress threshold to 0.5 for api key users#13517
Conversation
Summary of ChangesHello @scidomino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adjusts the default context compression threshold to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request changes the default compression threshold from 0.7 to 0.5. The change is applied consistently across the codebase, documentation, and configuration schemas. However, a unit test that relies on the old default value has not been updated, which will likely cause it to fail. I've left a comment with details on how to fix the test.
|
Size Change: -2 B (0%) Total Size: 21.1 MB ℹ️ View Unchanged
|
scidomino
force-pushed
the
tomm_compress
branch
from
7473f51 to
1813074
Compare
| label: 'Compression Threshold', | ||
| category: 'Model', | ||
| requiresRestart: true, | ||
| default: 0.7 as number, |
There was a problem hiding this comment.
optional nit: not new but this as number cast is surprising.
There was a problem hiding this comment.
I agree. I don't really understand why it's necessary, but it is.
|
/patch preview |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
4 participants
Summary
Changes the default compress threshold to 0.5 from 0.7.
Details
This adjusts the default compression threshold for api key users to 0.5.
Based on #13079
How to Validate
Start up and check the default in the settings screen.
Pre-Merge Checklist