Skip to content

fix(patch): cherry-pick c7b5dcd to release/v0.17.0-preview.2-pr-13517 to patch version v0.17.0-preview.2 and create version 0.17.0-preview.3#13529

Merged
skeshive merged 1 commit intorelease/v0.17.0-preview.2-pr-13517from
hotfix/v0.17.0-preview.2/0.17.0-preview.3/preview/cherry-pick-c7b5dcd/pr-13517
Nov 20, 2025
Merged

fix(patch): cherry-pick c7b5dcd to release/v0.17.0-preview.2-pr-13517 to patch version v0.17.0-preview.2 and create version 0.17.0-preview.3#13529
skeshive merged 1 commit intorelease/v0.17.0-preview.2-pr-13517from
hotfix/v0.17.0-preview.2/0.17.0-preview.3/preview/cherry-pick-c7b5dcd/pr-13517

Conversation

@gemini-cli-robot
Copy link
Copy Markdown
Collaborator

This PR automatically cherry-picks commit c7b5dcd to patch version v0.17.0-preview.2 in the preview release to create version 0.17.0-preview.3.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the process of updating a preview release by cherry-picking a specific commit. The primary functional change involves adjusting the default context compression threshold for models, which will cause context compression to trigger earlier than before. This update is reflected across documentation, configuration schemas, and the core service logic.

Highlights

  • Automated Cherry-Pick: This pull request is an automated cherry-pick of commit c7b5dcd to patch version v0.17.0-preview.2, leading to the creation of version 0.17.0-preview.3.
  • Default Compression Threshold Update: The default value for the model.compressionThreshold setting has been updated from 0.7 to 0.5. This change affects when context compression is triggered for models.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a commit to change the default model.compressionThreshold from 0.7 to 0.5. The change is applied consistently across the configuration schema, core service logic, and documentation. However, this change breaks an existing unit test that relies on the old default value. The test suite must be fixed for this change to be merged safely.

* token limit. If the chat history exceeds this threshold, it will be compressed.
*/
export const DEFAULT_COMPRESSION_TOKEN_THRESHOLD = 0.7;
export const DEFAULT_COMPRESSION_TOKEN_THRESHOLD = 0.5;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Changing DEFAULT_COMPRESSION_TOKEN_THRESHOLD to 0.5 causes a unit test to fail. The test 'should return NOOP if under token threshold and not forced' in chatCompressionService.test.ts is hardcoded with values that assume the threshold is 0.7. With the new value, the test's condition is no longer met, leading to failure. Please update the test to reflect the new default value.

@github-actions
Copy link
Copy Markdown

Size Change: -2 B (0%)

Total Size: 20.6 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.6 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@skeshive skeshive enabled auto-merge (squash) November 20, 2025 19:53
@skeshive skeshive merged commit d3bf3af into release/v0.17.0-preview.2-pr-13517 Nov 20, 2025
21 checks passed
@skeshive skeshive deleted the hotfix/v0.17.0-preview.2/0.17.0-preview.3/preview/cherry-pick-c7b5dcd/pr-13517 branch November 20, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants