fix(patch): cherry-pick c7b5dcd to release/v0.17.0-preview.2-pr-13517 to patch version v0.17.0-preview.2 and create version 0.17.0-preview.3#13529
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the process of updating a preview release by cherry-picking a specific commit. The primary functional change involves adjusting the default context compression threshold for models, which will cause context compression to trigger earlier than before. This update is reflected across documentation, configuration schemas, and the core service logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a commit to change the default model.compressionThreshold from 0.7 to 0.5. The change is applied consistently across the configuration schema, core service logic, and documentation. However, this change breaks an existing unit test that relies on the old default value. The test suite must be fixed for this change to be merged safely.
| * token limit. If the chat history exceeds this threshold, it will be compressed. | ||
| */ | ||
| export const DEFAULT_COMPRESSION_TOKEN_THRESHOLD = 0.7; | ||
| export const DEFAULT_COMPRESSION_TOKEN_THRESHOLD = 0.5; |
There was a problem hiding this comment.
Changing DEFAULT_COMPRESSION_TOKEN_THRESHOLD to 0.5 causes a unit test to fail. The test 'should return NOOP if under token threshold and not forced' in chatCompressionService.test.ts is hardcoded with values that assume the threshold is 0.7. With the new value, the test's condition is no longer met, leading to failure. Please update the test to reflect the new default value.
|
Size Change: -2 B (0%) Total Size: 20.6 MB ℹ️ View Unchanged
|
d3bf3af
into
release/v0.17.0-preview.2-pr-13517
This PR automatically cherry-picks commit c7b5dcd to patch version v0.17.0-preview.2 in the preview release to create version 0.17.0-preview.3.