Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the extension installation process by removing support for a specific shorthand notation for Git repositories. This change aims to improve forward compatibility and clarify the expected input format for extension sources, ensuring a more consistent and predictable user experience.
Highlights
- Deprecation of org/repo shorthand: The extensions install command no longer supports installing extensions using the org/repo shorthand (e.g., test-org/test-repo). Users must now provide the full Git URL.
- Code Simplification: Removed the regular expression and associated logic previously used to parse and convert org/repo strings into Git URLs, simplifying the installation source handling.
- Improved Error Messaging and Documentation: The error message for invalid installation sources has been updated to reflect that only valid URLs are accepted. Command descriptions have also been clarified.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes support for installing extensions using the 'org/repo' shorthand. The changes are well-contained and correctly implement the feature removal. The implementation in install.ts is simplified by removing the logic that handled the 'org/repo' format, and the corresponding error messages and command descriptions have been updated accordingly. The tests for the removed functionality in install.test.ts have also been correctly removed. The changes are straightforward and I did not find any issues with them.
|
Size Change: -277 B (0%) Total Size: 13.2 MB ℹ️ View Unchanged
|
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
TLDR
Removing this because we want to be forwards-compatible and to avoid making it seem like we're using npm.
Dive Deeper
Reviewer Test Plan
Testing Matrix
Linked issues / bugs