Skip to content

Remove org/repo install support #7815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrstnb merged 4 commits into from
Sep 9, 2025
Merged

Remove org/repo install support #7815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c57730a
Remove org/repo install support
chrstnb Sep 5, 2025
1203aae
install
chrstnb Sep 5, 2025
5f75f1a
Merge
chrstnb Sep 8, 2025
b2cceaa
Fix formatting
chrstnb Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions packages/cli/src/commands/extensions/install.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
*/

import { describe, it, expect } from 'vitest';
import { installCommand, handleInstall } from './install.js';
import { installCommand } from './install.js';
import yargs from 'yargs';
import * as extension from '../../config/extension.js';

vi.mock('../../config/extension.js', () => ({
installExtension: vi.fn(),
Expand All @@ -28,22 +27,3 @@ describe('extensions install command', () => {
).toThrow('Arguments source and path are mutually exclusive');
});
});

describe('extensions install with org/repo', () => {
it('should call installExtension with the correct git URL', async () => {
const consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
const installExtensionSpy = vi
.spyOn(extension, 'installExtension')
.mockResolvedValue('test-extension');

await handleInstall({ source: 'test-org/test-repo' });

expect(installExtensionSpy).toHaveBeenCalledWith({
source: 'https://github.com/test-org/test-repo.git',
type: 'git',
});
expect(consoleLogSpy).toHaveBeenCalledWith(
'Extension "test-extension" installed successfully and enabled.',
);
});
});
16 changes: 3 additions & 13 deletions packages/cli/src/commands/extensions/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ interface InstallArgs {
path?: string;
}

const ORG_REPO_REGEX = /^[a-zA-Z0-9-]+\/[\w.-]+$/;

export async function handleInstall(args: InstallArgs) {
try {
let installMetadata: ExtensionInstallMetadata;
Expand All @@ -34,15 +32,8 @@ export async function handleInstall(args: InstallArgs) {
source,
type: 'git',
};
} else if (ORG_REPO_REGEX.test(source)) {
installMetadata = {
source: `https://github.com/${source}.git`,
type: 'git',
};
} else {
throw new Error(
`The source "${source}" is not a valid URL or "org/repo" format.`,
);
throw new Error(`The source "${source}" is not a valid URL format.`);
}
} else if (args.path) {
installMetadata = {
Expand All @@ -66,12 +57,11 @@ export async function handleInstall(args: InstallArgs) {

export const installCommand: CommandModule = {
command: 'install [source]',
describe:
'Installs an extension from a git repository (URL or "org/repo") or a local path.',
describe: 'Installs an extension from a git repository URL or a local path.',
builder: (yargs) =>
yargs
.positional('source', {
describe: 'The git URL or "org/repo" of the extension to install.',
describe: 'The github URL of the extension to install.',
type: 'string',
})
.option('path', {
Expand Down
Loading