Skip to content

feat(core): Download ripgrep at runtime, if enabled.#7818

Merged
joshualitt merged 4 commits intogoogle-gemini:mainfrom
joshualitt:download-ripgrep
Sep 8, 2025
Merged

feat(core): Download ripgrep at runtime, if enabled.#7818
joshualitt merged 4 commits intogoogle-gemini:mainfrom
joshualitt:download-ripgrep

Conversation

@joshualitt
Copy link
Copy Markdown
Contributor

TLDR

Downloads ripgrep at runtime, if the feature is enabled.

Testing Matrix

🍏 🪟 🐧
npm run ✔️
npx
Docker
Podman - -
Seatbelt - -

Linked issues / bugs

Part of the work required to address #7327

@gemini-cli gemini-cli bot added kind/enhancement priority/p2 Important but can be addressed in a future release. labels Sep 5, 2025
@joshualitt joshualitt force-pushed the download-ripgrep branch 8 times, most recently from 34586b6 to 301af00 Compare September 5, 2025 21:40
@joshualitt
Copy link
Copy Markdown
Contributor Author

@mattKorwel for changes required to get this through CI.

@joshualitt joshualitt marked this pull request as ready for review September 5, 2025 21:47
@joshualitt joshualitt requested a review from a team as a code owner September 5, 2025 21:47
@joshualitt joshualitt removed the request for review from mattKorwel September 5, 2025 21:54
@joshualitt
Copy link
Copy Markdown
Contributor Author

@mattKorwel nevermind! I created #7833 with just the CI changes.

Copy link
Copy Markdown
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. a few minor comments then approved.

Copy link
Copy Markdown
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshualitt joshualitt enabled auto-merge September 8, 2025 21:40
@joshualitt joshualitt added this pull request to the merge queue Sep 8, 2025
Merged via the queue into google-gemini:main with commit f0bbfe5 Sep 8, 2025
20 checks passed
@joshualitt joshualitt deleted the download-ripgrep branch September 8, 2025 21:55
giraffe-tree pushed a commit to giraffe-tree/gemini-cli that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/p2 Important but can be addressed in a future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants