Check Vulkan 1.4 features for indexTypeUint8#1060
Check Vulkan 1.4 features for indexTypeUint8#1060lordalcol wants to merge 3 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| } | ||
| } | ||
|
|
||
| // If Vulkan 1.4 structure exists the features are set there. |
There was a problem hiding this comment.
What happens if vulkan 1.4 isn't provided, does this mean it can no longer find the feature it previously found? Does the old way not work anymore, like is VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_INDEX_TYPE_UINT8_FEATURES_EXT no longer returned above so the pointer isn't set?
There was a problem hiding this comment.
Sorry for messing up the PR. The new one (good, I hope) is at #1061
| return amber::Result( | ||
| "Subgroup extended types requested but feature not returned"); | ||
| } | ||
| if (feature == kAccelerationStructure && |
There was a problem hiding this comment.
yes, I think it's some merge gone bad. I'll re-do it
|
Abandoned in favour of #1061 |
4 participants
No description provided.