Skip to content

Add support for Vulkan 1.4#1061

Merged
dj2 merged 4 commits intogoogle:mainfrom
lordalcol:vulkan-1.4
Dec 3, 2024
Merged

Add support for Vulkan 1.4#1061
dj2 merged 4 commits intogoogle:mainfrom
lordalcol:vulkan-1.4

Conversation

@lordalcol
Copy link
Contributor

No description provided.

@lordalcol
Copy link
Contributor Author

@gfxstrand Since you were the original author of this, could you help replying and amending if needed?

@dj2
Copy link
Collaborator

dj2 commented Dec 3, 2024

The change looks good to me, just need to see if the bots are happy with it.

@lordalcol
Copy link
Contributor Author

The change looks good to me, just need to see if the bots are happy with it.

What about that other comment you left, that constrains uint8 to Vulkan 1.4?

@dj2
Copy link
Collaborator

dj2 commented Dec 3, 2024

Either I mis-read the other PR, or this one is different because it does do an if vk1.4 {} else { old thing }

@dj2
Copy link
Collaborator

dj2 commented Dec 3, 2024

(looking again, I mis-read the other PR, heh)

@lordalcol
Copy link
Contributor Author

I have a feeling it may need a Vulkan headers update. Not sure how to do it here.

@dj2
Copy link
Collaborator

dj2 commented Dec 3, 2024

Change the sha in the vulkan_headers_revision in the DEPS file.

@dj2
Copy link
Collaborator

dj2 commented Dec 3, 2024

I'm guessing you're going to need to do all the vulkan libraries as they tend to be intertwined.

@lordalcol
Copy link
Contributor Author

I'm guessing you're going to need to do all the vulkan libraries as they tend to be intertwined.

Yes, I'm doing them all now, checking locally too.

@dj2 dj2 merged commit 1ec5e96 into google:main Dec 3, 2024
@lordalcol lordalcol deleted the vulkan-1.4 branch December 3, 2024 18:21
@dj2
Copy link
Collaborator

dj2 commented Dec 3, 2024

Merged. Thanks a lot for the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants