Skip to content

Add support for DoDrawRect in dawn backend#498

Merged
dneto0 merged 13 commits intogoogle:masterfrom
sarahM0:rect2
May 13, 2019
Merged

Add support for DoDrawRect in dawn backend#498
dneto0 merged 13 commits intogoogle:masterfrom
sarahM0:rect2

Conversation

@sarahM0
Copy link
Contributor

@sarahM0 sarahM0 commented May 6, 2019 •
edited
Loading

  • Implements Dawn: Implement DoDrawRect #16
  • Add support for drawRect in Dawn backend
  • Update kokoro build for Dawn to use a fixed old version while Dawn creators are refactoring their work
  • Eliminated the need for module_for_typ_ state form EngineDawn by merging two functions
  • Added a temporary Helper struct to EngineDawn
  • struct Helper is used to create and initialize two dawn objects (RenderPassDescriptor and RenderPipelineDescriptor)

@sarahM0 sarahM0 changed the title WIP: support DoDrawRect for dawn backend Add support for DoDrawRect in dawn backend May 7, 2019
@sarahM0 sarahM0 added the enhancement New feature or request label May 7, 2019
@sarahM0 sarahM0 added this to the Dawn Engine milestone May 7, 2019
@sarahM0 sarahM0 requested review from dj2 and dneto0 May 8, 2019 15:42
dj2
dj2 reviewed May 8, 2019
View reviewed changes
@sarahM0 sarahM0 force-pushed the rect2 branch 2 times, most recently from a14c9af to d516c9e Compare May 9, 2019 17:18
dneto0
dneto0 requested changes May 9, 2019
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good.
Some funny stuff around entry point names.
Otherwise, a few nits.
Generally, please get in the habit of writing method comments. :-)

src/dawn/engine_dawn.cc Outdated
// Helper stuff
struct Helper {
::dawn::RenderPassColorAttachmentDescriptor*
cColorAttachmentsInfoPtr[kMaxColorAttachments];
Copy link
Collaborator

@dneto0 dneto0 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the "c" prefix on the name here, and "m" on mColorAttachmentsInfo?

We don't need those prefixes.

src/dawn/engine_dawn.cc Outdated
const float kLodMax = 1000.0;

// Helper stuff
struct Helper {
Copy link
Collaborator

@dneto0 dneto0 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a better name would be DawnPipelineInfo ?

Copy link
Contributor Author

@sarahM0 sarahM0 May 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about DawnPipelineHelper? it's not holding any info, basically it's there so a bunch of variables do not go out of scope while we need them.

src/dawn/engine_dawn.h Outdated
namespace amber {
namespace dawn {

static constexpr uint32_t kMaxColorAttachments = 4u;
Copy link
Collaborator

@dneto0 dneto0 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constexpr doesn't work in VS2013. I'm not sure if we care to support it or not.

If we need it, an alternative is

enum : uint32_t { kMaxColorAttachments = 4u, kMaxVertexInputs = 16u, kMaxVertexAttributes = 16u };

Copy link
Contributor Author

@sarahM0 sarahM0 May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's not needed I replaced it with const and moved them to the anonymes space in engine_dawn.cc.

src/dawn/engine_dawn.cc Outdated
// TODO(dneto): Handle other shader types as well. They are optional.
auto vs = module_for_type_[kShaderTypeVertex];
auto fs = module_for_type_[kShaderTypeFragment];
auto vs = module_for_type[kShaderTypeVertex];
Copy link
Collaborator

@dneto0 dneto0 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, make this auto&

src/dawn/engine_dawn.cc Outdated
renderPipelineDescriptor.sampleCount = 1;

// Set defaults for the vertex stage descriptor.
snprintf(entryPoint,
Copy link
Collaborator

@dneto0 dneto0 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an awful lot of work. Also, where is it writing the data to? No memory has been allocated to it.
I would change entryPoint to a std::string, and then:

entryPoint = ... GetEntryPoint()
...
cVertexStage.entryPoint = entryPoint.c_str();

Copy link
Collaborator

@dneto0 dneto0 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, why is it always the [0] entry of the GetShaders result? Shouldn't we look it up by shader type?

src/dawn/engine_dawn.cc Outdated

// Set defaults for the fragment stage descriptor.
cFragmentStage.module = render_pipeline.fragment_shader;
cFragmentStage.entryPoint = entryPoint;
Copy link
Collaborator

@dneto0 dneto0 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fragment shader entry point name can be different. You need to look it up again. And I think do that by fragment shader type?

@sarahM0 sarahM0 requested a review from dneto0 May 10, 2019 19:40
dneto0
dneto0 reviewed May 13, 2019
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there. :-)

src/dawn/engine_dawn.cc

// This structure is a container for a few variables that are created during
// CreateRenderPipelineDescriptor and CreateRenderPassDescriptor and we want to
// make sure they don't go out of scope before we are done with them
Copy link
Collaborator

@dneto0 dneto0 May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment about the lifetime of the values is insightful. Lifecycle info is an important aspect that's often overlooked, and the source of bugs.

src/dawn/engine_dawn.h Outdated
std::unordered_map<amber::Pipeline*, ::amber::dawn::Pipeline> pipeline_map_;

// TODO(dneto): Remove this. Shaders are attached to the pipeline.
std::unordered_map<ShaderType, ::dawn::ShaderModule, CastHash<ShaderType>>
Copy link
Collaborator

@dneto0 dneto0 May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable should be deleted now. You've absorbed it into one of the methods.

src/dawn/engine_dawn.cc Outdated
::dawn::VertexAttributeDescriptor vertexAttribute;
::dawn::BlendDescriptor blend;
::dawn::ColorStateDescriptor colorStateDescriptor;
std::string vertextEntryPoint;
Copy link
Collaborator

@dneto0 dneto0 May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling: "vertexEntryPoint"

dneto0
dneto0 requested changes May 13, 2019
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous

@dneto0 dneto0 merged commit 0bb9964 into google:master May 13, 2019
@dj2 dj2 mentioned this pull request Feb 18, 2020
Merged
dj2 added a commit that referenced this pull request Feb 19, 2020
@dj2
Rolling 14 dependencies (#787)
2b3466e 
Roll third_party/clspv/ 50e3cd23a..51952284d (4 commits)

google/clspv@50e3cd2...5195228

$ git log 50e3cd23a..51952284d --date=short --no-merges --format='%ad %ae %s'
2020-02-14 jrprice Fix stores to widening pointer casts (#505)
2020-01-29 alanbaker Update deps (#502)
2020-01-29 alanbaker Upgrade the GCC used in for Linux Kokoro bots (#501)
2020-01-29 alanbaker Don't add int64 types due to literal operands (#498)

Roll third_party/clspv-llvm/ ac9b2a629..1cff2aa51 (2245 commits)

llvm/llvm-project@ac9b2a6...1cff2aa

$ git log ac9b2a629..1cff2aa51 --date=short --no-merges --format='%ad %ae %s'
2020-02-18 ldionne [libc++] Remove XFAILs for macOS 10.15, which were fixed in later dot releases
2020-02-18 djordje.todorovic Reland "[DebugInfo] Enable the debug entry values feature by default"
2020-02-18 benny.kra Move DFA tables into the read-only data segmant.
2020-02-10 Milos.Stojanovic [llvm-exegesis] Improve error reporting in Assembler.cpp
2020-02-17 modocache [IR] Set name when inserting 'llvm::Value*'
2020-02-18 jrtc27 Use SETNE directly rather than SUB/SETNE 0 for stack guard check
2020-02-18 cristian.adam llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable
2020-02-18 teemperor [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create
2020-02-18 tatyana [lldb][test] Remove expected failure decorator from test_copy_from_dummy_target (TestScriptedResolver)
2020-02-17 flo [CGP] Add uaddo test with math used, SPARC/AArch64 variants.
2020-02-12 grimar [llvm-readobj] - Report a warning when an unexpected DT_SYMENT tag value is met.
2020-02-18 sguelton Fix riscv/lld test interaction
2020-02-18 djordje.todorovic [CSInfo][TailDuplicator] Delete the call site info when removing dead MBBs
2020-02-12 tatyana [lldb][NFC] Remove unused parameter
2020-02-13 tatyana [lldb] Make shared_from_this-related code safer
2020-02-13 tatyana [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor
2020-02-18 kerry.mclaughlin [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations
2020-02-18 teemperor [lldb][NFC] Fix compilation of SymbolFilePDBTests.cpp after FindNamespace API change
2020-02-17 sguelton Support -fuse-ld=lld for riscv
2020-02-18 mikhail.maltsev [ARM,CDE] Cosmetic changes, additonal driver tests
2020-02-18 teemperor [lldb] Don't model std::atomic as a transparent data structure in the data formatter
2020-02-17 pavel [lldb/DWARF] Support the debug_str_offsets section in dwp files
2020-02-18 sven.vanhaastregt [OpenCL] Add Arm dot product builtin functions
2020-02-18 teemperor [lldb] Fix compilation of SymbolFilePDBTests.cpp after FindTypes API change
2020-02-18 pavel [lldb] Remove DataExtractor::GetPointer
2020-02-17 simon.tatham [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.
2020-02-17 simon.tatham [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family.
2020-02-17 simon.tatham [ARM] Allow `ARMVectorRegCast` to match bitconverts too. (NFC)
2020-02-17 simon.tatham [ARM,MVE] Add intrinsics vclzq and vclsq.
2020-02-17 simon.tatham [ARM,MVE] Add the vrev16q, vrev32q, vrev64q family.
2020-02-17 simon.tatham [ARM,MVE] Add intrinsics for FP rounding operations.
2020-02-17 simon.tatham [ARM,MVE] Add intrinsics for int <-> float conversion.
2020-02-17 simon.tatham [ARM,MVE] Add intrinsics for abs, neg and not operations.
2020-02-18 teemperor [lldb][NFC] Documention that OptionDefinition::completion_type contains enum values
2020-02-18 pavel [lldb] Remove the mutable specifier from DataExtractor's member
2020-02-18 teemperor [lldb][NFC] Modernize documentation in lldb-private-types.h
2020-02-18 daniel.kiss [LLD][ELF][AArch64] Change the semantics of -z pac-plt.
2020-02-18 teemperor [lldb] Refactor and test TypeSystemClang::GetEnumerationIntegerType
2020-02-18 flo [InstCombin] Avoid nested Create calls, to guarantee order.
2020-02-18 flo [InstCombine] Simplify a umul overflow check to a != 0 && b != 0.
2020-02-18 teemperor [lldb][NFC] Document TypeSystemClang
2020-02-17 teemperor [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers
2020-02-18 gokturk [Support] Check for atomics64 when deciding if '-latomic'  is needed
2020-02-17 flo [InstCombine] Precommit umul.with.overflow sign check test.
2020-02-17 jonas [lldb] Replace #pragma once with header guard
2020-02-17 teemperor [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.
2020-02-18 a.v.lapshin [Debuginfo][NFC] add comments for WithColor routines.
2020-02-17 jonas [lldb] Update header guards to be consistent and compliant with LLVM (NFC)
2020-02-17 jonas [lldb] Replace empty ctor en dtor bodies with =default (NFC)
2020-02-18 artem.dergachev Revert "[analyzer] Teach scan-build how to rebuild index.html without analyzing."
(...)
2020-01-27 smeenai [libcxx] Link against android_support when needed
2020-01-27 smeenai [asan] Fix test compilation on Android API <= 17
2020-01-27 smeenai [runtimes] Fix passing lists to runtimes configures
2020-01-28 benny.kra Make llvm::StringRef to std::string conversions explicit.
2020-01-27 apl [lldb] Delete ValueObject::GetBaseClassPath
2020-01-28 danilo.carvalho.grael [AArch64][SVE] Add SVE2 mla indexed intrinsics.
2020-01-28 jpaquette [AArch64][GlobalISel] Fold G_AND into G_BRCOND
2020-01-27 francisvm [CodeGen] Attach no-builtin attributes to function definitions with no Decl
2020-01-23 apl [lldb] Remove ClangASTImporter from Target
2020-01-28 mtrofin [llvm] Ensure InlineCost-related fields are initialized
2020-01-28 spang [GlobalMerge] Preserve symbol visibility when merging globals
2020-01-28 hans Revert "[MS] Overhaul how clang passes overaligned args on x86_32"
2020-01-28 jonas [lldb/Reproducer] Include deserialized value in log statement
2020-01-28 mgorny [lldb] [test] Restrict x86-64-write register test to x86-64
2020-01-28 thakis [gn build] (manually) port 90a10f00ff8
2020-01-28 ntv [mlir][Linalg][doc] Add Design Document for the Linalg Dialect
2020-01-28 asbirlea [LoopUnrollAndJamPass] Clean unnecessary includes. [NFCI]
2020-01-28 whitneyt [NFCI][LoopUnrollAndJam] Minor changes.
2020-01-27 phosek [Instrumentation] Set hidden visibility for the bias variable
2020-01-28 alexandre.ganea Fix compiling with clang-cl inside a Visual Studio 2019 16.4 command prompt.
2020-01-28 spatel [InstCombine] refactor foldVectorCmp(); NFC
2020-01-27 phosek [CMake] Set ASM compiler for external projects
2020-01-28 ted.woodward Don't fail step out if remote server doesn't implement qMemoryRegionInfo
2020-01-28 mcgrathr [lsan] Support LeakSanitizer runtime on Fuchsia
2020-01-28 mcgrathr [Fuchsia] Remove aarch64-fuchsia target-specific -mcmodel=kernel
2020-01-24 ataei [mlir] Add primitive transform pattern to rewrite linalg.fill into vector.broadcast form.
2020-01-28 riddleriver [mlir] Optimize OpResult use case for single result operations.
2020-01-28 dblaikie llvm-symbolizer test: Add a bit of extra detail on how to compile/reproduce this
2020-01-28 i [ELF][PPC32] Support --emit-relocs link of R_PPC_PLTREL24
2020-01-28 kostyak [scudo][standalone] Fix Android logging
2020-01-28 llvmgnsyncbot [gn build] Port 2c03c899d50
2020-01-27 yamauchi [MBFI] Move BranchFolding::MBFIWrapper to its own files. NFC.
2020-01-28 yaxun.liu Fix test hip-device-libs.hip
2020-01-28 jonas [lldb/Bindings] Sort headers in headers.swig
2020-01-14 kbessonova [llvm-dwarfdump][Statistics] Make calculations of vars in global scope more accurate
2020-01-14 kbessonova [llvm-dwarfdump][Statistics] Distinguish parameters with same name or w/o a name
2020-01-08 kbessonova [llvm-dwarfdump][Statistics] Count more than one conrete out-of-line instances of a function
2020-01-28 spatel [InstCombine] add tests for cmp with splat operand and splat constant; NFC
2020-01-28 llvmgnsyncbot [gn build] Port a928d127a52
2020-01-28 Konstantin.Pyzhov Corrected clang amdgpu-features.cl test for 6d614a82a4230ea69e322f56dc18dcbd815ed37b (AMDGPU MFMA built-ins)
2020-01-22 tra [CUDA] Assume the latest known CUDA version if we've found an unknown one.
2020-01-28 n.james93 [clang-tidy] adjust scripts to subsubsections in Release Notes
2020-01-27 aemerson [AArch64][GlobalISel] Don't bail out of the select(cmp(a, b)) -> csel optimization with multiple users.
2020-01-28 aaron Fix a crash when casting _Complex and ignoring the results.
2020-01-22 dschuff [WebAssembly] Add WebAssembly support to llvm-symbolizer
2020-01-19 kbessonova [llvm-dwarfdump][Statistics] Ignore declarations of global variables
2020-01-09 kbessonova [llvm-dwarfdump][Statistics] Ignore DW_TAG_subroutine_type in statistics
2020-01-14 kbessonova [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs
2019-11-22 dschuff [llvm-objcopy] Initial support for wasm in llvm-objcopy
2020-01-28 medismail.bennani Revert "[lldb/Target] Add Assert StackFrame Recognizer"

Roll third_party/dxc/ 32168eac8..de35705c7 (20 commits)

microsoft/DirectXShaderCompiler@32168ea...de35705

$ git log 32168eac8..de35705c7 --date=short --no-merges --format='%ad %ae %s'
2020-02-14 grroth Separate generation of DXC macro version info (#2681)
2020-02-14 python3kgae Update name and fix nonuniformindex. (#2697)
2020-02-13 31109344+adam-yang hlslFlags is now a null-terminator separated list of compiler options (excluding target, entry, and defines) (#2698)
2020-02-13 31109344+adam-yang Using DxilValueCache for unroll. (#2694)
2020-02-12 python3kgae Add GetResourceFromHeap. (#2691)
2020-02-11 hekotas Enable parallel build by default (#2689)
2020-02-11 hekotas When in detached head state do not include "HEAD" in product version string (#2690)
2020-02-11 grroth Avoid validation failure when missing annotation (#2687)
2020-02-11 hekotas DXBC to DXIL Converter + unit tests (#2685)
2020-02-10 31109344+adam-yang Fixed lack of constant folding sometimes putting instructions before PHI's. (#2683)
2020-02-10 hekotas Update version to 1.5.2002 (#2684) (#2686)
2020-02-06 hekotas HLSL test infrastucture and other refactoring and helper classes (#2682)
2020-02-06 texr Add missing UTF8 for source and output filenames (#2674)
2020-02-04 python3kgae Check hasName before getName for StructType. (#2678)
2020-02-03 grroth Correct include of absolute '/' paths on windows (#2671)
2020-02-03 grroth Relax dxc version macro tests (#2676)
2020-01-30 31109344+adam-yang Fixed incorrect PHI value in DxilValueCache. Also using it in a few more places. (#2668)
2020-01-30 grroth Add HLSL macros with version information (#2665)
2020-01-30 python3kgae Merge fix for undef in first_iteration case from upstream. (#2672)
2020-01-29 grroth Fix crash when using precise matrix with -Od (#2670)

Roll third_party/glslang/ 07a55839e..113d07a6e (9 commits)

KhronosGroup/glslang@07a5583...113d07a

$ git log 07a55839e..113d07a6e --date=short --no-merges --format='%ad %ae %s'
2020-02-18 swda.durl Add an option to make RTTI enabled
2020-02-06 kainino Split "is emscripten" config from "enable glslang.js"
2020-02-06 dneto Avoid enum-compare warning
2020-02-06 rex.xu Fix a parser error of GL_KHR_memory_scope_semantics
2020-01-23 kainino glslang.js: Make the SPIR-V target version configurable (1.0 ~ 1.5)
2020-02-02 timo.suoranta Fix memory corruption in TGlslIoMapper
2020-01-29 jbolz Use NOT ... VERSION_LESS instead of VERSION_GREATER_EQUAL
2020-01-28 jordan.l.justen standalone: Fix --help
2019-12-23 laddoc Add constant expression with mod

Roll third_party/googletest/ 10b1902d8..23b2a3b1c (21 commits)

google/googletest@10b1902...23b2a3b

$ git log 10b1902d8..23b2a3b1c --date=short --no-merges --format='%ad %ae %s'
2020-02-12 absl-team Googletest export
2020-02-11 absl-team Googletest export
2020-02-11 absl-team Googletest export
2020-02-10 absl-team Googletest export
2020-02-10 absl-team Googletest export
2020-02-07 absl-team Googletest export
2020-02-07 absl-team Googletest export
2020-02-06 durandal Googletest export
2020-02-05 absl-team Googletest export
2020-02-05 absl-team Googletest export
2020-02-03 absl-team Googletest export
2020-02-03 absl-team Googletest export
2020-01-31 absl-team Googletest export
2020-01-31 absl-team Googletest export
2020-01-29 absl-team Googletest export
2020-01-27 absl-team Googletest export
2020-01-27 absl-team Googletest export
2020-01-27 absl-team Googletest export
2020-01-24 absl-team Googletest export
2020-01-24 absl-team Googletest export
2020-01-23 absl-team Googletest export

Roll third_party/json/ ad383f66b..456478b3c (1 commit)

nlohmann/json@ad383f6...456478b

$ git log ad383f66b..456478b3c --date=short --no-merges --format='%ad %ae %s'
2019-07-21 mail 🚨 fix linter warning

Roll third_party/lodepng/ 5a0dba103..48e5364ef (5 commits)

lvandeve/lodepng@5a0dba1...48e5364

$ git log 5a0dba103..48e5364ef --date=short --no-merges --format='%ad %ae %s'
2020-02-16 lvandeve handle getTreeInflateFixed error, and fix stray memcpy
2020-02-15 lvandeve more memory allocation simplifications, and fixes of out of memory handling
2020-02-15 lvandeve cleanups and cast fixes
2020-02-12 lvandeve fix error handling of failed allocation, and remove unneeded palette realloc
2020-02-12 lvandeve fix memory leaks which could occur when returning error after allocations failed

Roll third_party/shaderc/ 821d564bc..738f1655a (8 commits)

google/shaderc@821d564...738f165

$ git log 821d564bc..738f1655a --date=short --no-merges --format='%ad %ae %s'
2020-02-10 rharrison Add newline to logging messages to make them readable (#985)
2020-02-06 rharrison Reduce amount of duplicated code in API implementations (#984)
2020-02-05 rharrison Add in support for spvc logging to the terminal (#981)
2020-02-05 rharrison Rolling 4 dependencies and updated expectations (#983)
2020-01-30 rharrison Add documentation for Vulkan 1.2 and SPIR-V 1.5 (#980)
2020-01-30 dneto Better help for glslc -S (#978)
2020-01-29 rharrison Add back in deprecated APIs (#977)
2020-01-28 kainino1 Make a source_set for libshaderc_spvc (#976)

Roll third_party/spirv-headers/ dc77030ac..5dbc1c321 (1 commit)

KhronosGroup/SPIRV-Headers@dc77030...5dbc1c3

$ git log dc77030ac..5dbc1c321 --date=short --no-merges --format='%ad %ae %s'
2020-02-07 michael.kinsner Allocate three bits for upcoming Intel extension

Roll third_party/spirv-tools/ 97f1d485b..79f8caf91 (23 commits)

KhronosGroup/SPIRV-Tools@97f1d48...79f8caf

$ git log 97f1d485b..79f8caf91 --date=short --no-merges --format='%ad %ae %s'
2020-02-18 bclayton vscode: Add missing fields to schema.Opcode (#3169)
2020-02-18 siglesias spirv-val: Add support for SPV_AMD_shader_image_load_store_lod (#3186)
2020-02-14 afdx spirvfuzz: Fix type-related bug, change undef to zero, and add assert (#3188)
2020-02-11 afdx spirv-fuzz: Fuzzer pass that adds access chains (#3182)
2020-02-10 afdx spirv-fuzz: Fuzzer pass to add function calls (#3178)
2020-02-10 afdx spirv-fuzz: Ensure that donated variables are always initialized (#3181)
2020-02-06 afdx spirv-fuzz: Add fuzzer passes to add loads/stores (#3176)
2020-02-05 afdx spirv-fuzz: Fuzzer passes to add local and global variables (#3175)
2020-02-04 bclayton utils/vscode: LSP - Support OpExtInst (#3140)
2020-02-04 kubak Fix typos in opt's help. Update environment version. (#3170)
2020-02-04 stevenperron Start SPIRV-Tools v2020.2
2020-02-04 stevenperron Finalize SPIRV-Tools v2020.1
2020-02-04 stevenperron Update CHANGES
2020-02-04 afdx spirv-fuzz: Fuzzer pass to add composite types (#3171)
2020-02-04 afdx Update script that checks copyright years. (#3173)
2020-02-04 afdx spirv-fuzz: Disallow copying of null and undefined pointers (#3172)
2020-02-03 dnovillo Handle TimeAMD in AmdExtensionToKhrPass. (#3168)
2020-02-03 stevenperron Update CHANGES
2020-02-03 arseny.kapoulkine Implement constant folding for many transcendentals (#3166)
2020-01-30 afdx Fix typo in comment. (#3163)
2020-01-30 afdx spirv-fuzz: Arbitrary variable facts (#3165)
2020-01-29 afdx spirv-fuzz: Add outlining test (#3164)
2020-01-29 afdx spirv-fuzz: Make functions "livesafe" during donation (#3146)

Roll third_party/swiftshader/ ce54c59e6..0bbf7ba9f (29 commits)

https://swiftshader.googlesource.com/SwiftShader.git/+log/ce54c59e657d..0bbf7ba9f909

$ git log ce54c59e6..0bbf7ba9f --date=short --no-merges --format='%ad %ae %s'
2020-02-17 amaiorano Cache callstack results to avoid expensive lookup
2020-02-14 amaiorano Subzero: add REACTOR_EMIT_PRINT_LOCATION support
2020-02-13 bclayton third_party: Add shell script that updates marl.
2020-02-13 amaiorano Implement rr::Print support for Subzero
2020-02-14 amaiorano Subzero: fix another load from constant data
2020-02-15 swiftshader.regress Regres: Update test lists @ 348f07b4
2020-02-14 amaiorano Fix unit test when ENABLE_RR_EMIT_PRINT_LOCATION is defined
2020-01-08 jonahr Implement HostMappedForeignMemory DeviceMemory
2020-02-13 bclayton Squashed 'third_party/marl/' changes from 246091e81..a047dd0bb
2020-02-10 bclayton third_party/marl: Add mips64 support to BUILD.gn
2020-02-13 swiftshader.regress Regres: Update test lists @ ac4e1d23
2020-02-12 amaiorano Kokoro: build and run rr::Print unit tests
2020-02-11 amaiorano Fix rr::Print and add unit tests
2020-02-11 gmouse Add missed symbol __aeabi_idivmod for Android.
2020-02-12 swiftshader.regress Regres: Update test lists @ 6cbb02e0
2020-02-07 bclayton CMakeLists: Drop the explicit include path to marl
2020-02-11 bclayton Bulk clang format
2020-02-08 bclayton Change SpirvShaderInstructions.inc extension to .inl
2020-02-09 jiaxun.yang Fix MIPS build cflags
2020-02-10 bclayton Don't use std::initializer_list for array views.
2020-02-10 sugoi Support for VK_KHR_separate_depth_stencil_layouts
2020-02-07 sugoi Support for VK_KHR_create_renderpass2
2020-02-11 bclayton Revert "Add missed symbol __aeabi_idivmod for Android."
2020-02-10 gmouse Add missed symbol __aeabi_idivmod for Android.
2020-02-10 bclayton Debug: Rename levels.
2020-02-09 bclayton Squashed 'third_party/marl/' changes from 14e4d862a..246091e81
2020-02-08 bclayton Fix Android build: Add missing .cpp to Android.bp
2020-02-07 amaiorano Subzero: fix cosh/sinh deqp failures
2020-02-07 amaiorano ReactorUnitTests: fix clang-format messing up test suites

Roll third_party/vulkan-headers/ 726435870..9bd3f561b (1 commit)

KhronosGroup/Vulkan-Headers@7264358...9bd3f56

$ git log 726435870..9bd3f561b --date=short --no-merges --format='%ad %ae %s'
2020-02-15 oddhack Update for Vulkan-Docs 1.2.133

Roll third_party/vulkan-loader/ 44ac9b2f4..0bd30e43c (11 commits)

KhronosGroup/Vulkan-Loader@44ac9b2...0bd30e4

$ git log 44ac9b2f4..0bd30e43c --date=short --no-merges --format='%ad %ae %s'
2020-02-17 shannon build: Update known-good for 1.2.133 header
2020-02-06 cnorthrop loader: Avoid clang warning about parentheses
2020-02-05 charles loader: secure_getenv change logging WARN to INFO
2020-01-27 charles loader: don't unconditionally add std-val meta layer
2020-02-05 lenny loader: Fix buffer size updates in registry search
2020-02-04 lenny loader: Add core 1.2 functions to gpa_helper
2020-02-03 charles loader: add null check to loaderValidateLayers
2020-02-04 charles loader: Warn when loader_secure_getenv() fails
2020-01-31 lenny build: Regenerate files for debug utils changes
2020-01-31 lenny loader: Fix debug utils terminators being skipped
2020-01-28 shannon build: Update known-good for 1.2.132 header

Roll third_party/vulkan-validationlayers/ c51d450ef..873e416c2 (74 commits)

KhronosGroup/Vulkan-ValidationLayers@c51d450...873e416

$ git log c51d450ef..873e416c2 --date=short --no-merges --format='%ad %ae %s'
2020-02-13 mark tests: Touch up some incorrect errorMonitor calls
2020-02-13 mark tests: Added tests for CmdBlitImage planar VUIDs
2020-02-13 mark corechecks: Add CmdBlitImage multiplanar format checks
2020-02-13 s.fricke tests: Add test for vkCmdCopyImage VUID
2020-02-13 s.fricke layers: Add support for vkCmdCopyImage VUID
2020-02-14 mark corechecks: Correct conditions for triggering VUID 1564
2020-02-12 tony layers: Fix false errors if query condition is unknown
2020-02-12 mark layers: Fix string validation returned results
2020-02-10 mikes scripts: Rename src argument for safe_* copy funcs
2020-02-06 mikes scripts: Only use safe_* types when needed
2020-02-03 mikes scripts: Handle arrays with const/non-member len
2018-12-10 shannon scripts: Fix codegen infinite recursion
2020-02-09 s.fricke tests: Add test for 01004 and 02652
2020-02-09 s.fricke layers: Add support for 01004 and 02652
2020-02-10 mark tests: Remove non-API range enums
2020-02-10 mark layers: Remove non-API range enums
2020-02-11 mark layers: Remove deprecated log_msg() function
2020-02-12 mark layers: Removed last log_msg calls
2020-02-09 s.fricke tests: Added test for 00624 and 00625
2020-02-09 s.fricke stateless: Added support for 00624 and 00625
2020-02-11 s.fricke tests: Add test for 00360
2020-02-11 s.fricke layers: Add support for 00360
2020-02-09 s.fricke tests: Add tests for 01973 and 01069
2020-02-09 s.fricke layers: Add support for 01973 and 01069
2020-02-11 mark layers: Update stateless validation doc
2020-01-31 mark corechecks: Convert core val to use new logging funcs
2020-01-31 mark corechecks: Converted buffer validation to new logging funcs
2020-01-30 mark corechecks: Use new logging calls in shader validation
2020-01-30 mark corechecks: Move helpers inside validation object
2020-01-30 mark threading: Change log_msg calls to LogError calls
2020-01-30 mark theading: Pass object pointer instead of report_data
2020-01-30 mark corechecks: Move misplaced validation call into core validation
2020-01-30 mark chassis: Changed log_msg calls to LogWarning calls
2020-01-30 mark corechecks: Convert drawdispatch.cpp to new logging funcs
2020-01-29 mark gpuval: Moved to new-style logging functions
2020-01-15 mark corechecks: Converted descriptor_sets.cpp to new logging calls
2020-01-29 mark practices: Convert WARNINGS to new logging calls
2020-01-29 mark practices: Convert perf warnings to new logging funcs
2020-01-29 mark practices: Change info message to warning
2020-01-29 mark objlifetimes: Convert object tracker to new logging calls
2020-01-23 mark stateless: Convert parameter validation to new logging calls
2020-02-11 mark tests: Fix pipeline create state test
2020-02-09 s.fricke tests: Added test for 00701
2020-02-09 s.fricke layers: Added support for 00701
2020-02-09 s.fricke layers: Added condition to display 01427
2020-02-09 s.fricke layers: Added condition to display 01430
2020-02-09 s.fricke tests: Added test for 01988
2020-02-09 s.fricke layers: Added support for 01988
2020-02-10 s.fricke tests: Added test for 01143
2020-02-10 s.fricke layers: Added support for 01143
2020-02-10 s.fricke tests: Added test for 00317 and 00318
2020-02-10 s.fricke layers: Added support for 00317 and 00318
2020-02-05 raul.tambre layers: Don't issue VU01564 for immutable samplers
2020-02-10 jeremy tests: Test unaligned CmdPushDescriptorSet
2020-02-10 jeremy layers: Validate unaligned CmdPushDescriptorSet
2020-02-06 jzulauf tests: Add layout for middle subresource test
2020-02-06 jzulauf layers: Fix range_vector excess erasure
2020-02-07 jeremy layers: Fix unitialized variable.
2020-02-05 brucedawson Fix duplicate header file entry
2020-02-05 mark tests: Revert "Call 1.2 core API using GetInstanceProcAddr"
2020-02-05 mark tests: Call 1.2 core API using GetInstanceProcAddr
2020-02-04 mark chassis: Limit GetPhysDevProcAddr to physical device funcs
2020-02-03 tony layers: Use correct VK version when validating spec consts
2020-02-04 tony tests: Use maxBoundDescriptorSets instead of hard coding
2019-12-20 tony gpu: Use updated interface to instrumentation
2020-01-30 s.fricke tests: Added tests for Ycbcr in vkCreateImage
2020-01-30 s.fricke layers: Added Ycbcr support in VkImageCreateInfo
2020-01-31 tony layers: Use safe_VkImageCreateInfos
2020-01-31 tobine build: Add NOMINMAX to Win ninja build
2020-01-29 mark build: Move NOMINMAX definition from src to cmake file
2020-01-28 shannon build: Update known-good for 1.2.132 header
2020-01-28 tony layers: Fix call to overwrite_range
2020-01-20 s.fricke tests: Added test for VUID 02283
2020-01-20 s.fricke layers: Added VUID 02283

Created with:
  roll-dep third_party/clspv third_party/clspv-llvm third_party/cppdap third_party/dxc third_party/glslang third_party/googletest third_party/json third_party/lodepng third_party/shaderc third_party/spirv-headers third_party/spirv-tools third_party/swiftshader third_party/vulkan-headers third_party/vulkan-loader third_party/vulkan-validationlayers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dj2 dj2 dj2 left review comments

@dneto0 dneto0 dneto0 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarahM0 @dj2 @dneto0