layouts: split footer partial in several partials#1500
Merged
chalin merged 1 commit intogoogle:mainfrom Feb 2, 2024
Merged
Conversation
This was referenced Apr 21, 2023
deining
suggested changes
Apr 21, 2023
Contributor
There was a problem hiding this comment.
In general, I'm fine with these changes. Directory layouts/partials contains a lot of files already, therefore I would propose to create a new directory layouts/partials/footer and put the newly introduced files foooter-xxx.htmlinto that directory.
yann-soubeyrand
force-pushed
the
split-footer
branch
from
635a733 to
bd937f7
Compare
Contributor
Author
|
That’s indeed a good idea! |
yann-soubeyrand
force-pushed
the
split-footer
branch
from
bd937f7 to
0e07183
Compare
yann-soubeyrand
commented
Apr 21, 2023
yann-soubeyrand
force-pushed
the
split-footer
branch
from
0e07183 to
75de4a3
Compare
Contributor
|
That's just what I was looking for, I hope it gets merged soon. Thanks! |
Collaborator
|
Hi @yann-soubeyrand: thanks for this. I'm eager to look at it once the BS v5.2 upgrade is done and the next release of Docsy is out. Could you resolve conflicts in the meantime? Thanks! |
yann-soubeyrand
force-pushed
the
split-footer
branch
from
75de4a3 to
1f6fc75
Compare
Contributor
Author
|
Hi @chalin, it’s done 😉 |
yann-soubeyrand
force-pushed
the
split-footer
branch
2 times, most recently
from
3f4f6f1 to
c93ee1c
Compare
yann-soubeyrand
force-pushed
the
split-footer
branch
from
c93ee1c to
4233cc7
Compare
yann-soubeyrand
force-pushed
the
split-footer
branch
from
4233cc7 to
e3239a4
Compare
yann-soubeyrand
force-pushed
the
split-footer
branch
2 times, most recently
from
9e33776 to
976832d
Compare
This allows to more easily override some parts of the footer. Signed-off-by: Yann Soubeyrand <yann.soubeyrand@gmx.fr>
This was referenced Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to more easily override some parts of the footer.
Related: