Skip to content

Footer, copyright notice: allow customization of year#1593

Merged
chalin merged 1 commit intogoogle:mainfrom
deining:copyright-year
Feb 2, 2024
Merged

Footer, copyright notice: allow customization of year#1593
chalin merged 1 commit intogoogle:mainfrom
deining:copyright-year

Conversation

@deining
Copy link
Copy Markdown
Contributor

@deining deining commented Jun 26, 2023

Following up on #1592, this PR allows to customize the year displayed in the footer's copyright notice. This is done via specifying .Site.Params.copyright.year in your config file.

This PR closes #1592

Closes #2

@deining deining requested a review from chalin June 26, 2023 20:01
Comment thread layouts/partials/footer.html Outdated
@deining deining force-pushed the copyright-year branch 2 times, most recently from 3dbf2e6 to a540ee8 Compare June 27, 2023 20:45
@deining deining requested a review from yann-soubeyrand June 27, 2023 20:46
Comment thread layouts/partials/footer.html Outdated
Copy link
Copy Markdown
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LisaFC et al.: this was slated for discussion at the PSC but wasn't addressed. I've added it for a topic of discussion at our next meeting. Let's hold on merging this until then.

@chalin
Copy link
Copy Markdown
Collaborator

chalin commented Jul 27, 2023

Just a note to self that I'll likely want to look at the following first:

@chalin chalin mentioned this pull request Feb 2, 2024
33 tasks
@chalin
Copy link
Copy Markdown
Collaborator

chalin commented Feb 2, 2024

PR #1500 has landed. I've proposed a further refactoring via #1817. Once it lands, could you resolve conflicts in this PR?

@deining
Copy link
Copy Markdown
Contributor Author

deining commented Feb 2, 2024

All conflicts resolved, checkers are green. This PR is ready for merging now IMHO.

@deining deining requested a review from chalin February 2, 2024 20:50
Copy link
Copy Markdown
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll follow up with some adjustments in support of #436.

@chalin chalin merged commit 9c3f91b into google:main Feb 2, 2024
@deining deining deleted the copyright-year branch February 2, 2024 22:16
@chalin chalin added this to the 24Q1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copyright year The footer should allow a more flexible copyright statement

3 participants