Fix EXECUTE-AS-TEMPLATE error with offline-search-index.json (issue #705)#710
Merged
LisaFC merged 2 commits intogoogle:masterfrom Oct 4, 2021
Merged
Fix EXECUTE-AS-TEMPLATE error with offline-search-index.json (issue #705)#710LisaFC merged 2 commits intogoogle:masterfrom
LisaFC merged 2 commits intogoogle:masterfrom
Conversation
Collaborator
|
Excellent, thanks! |
chalin
reviewed
Oct 6, 2021
Comment on lines
-4
to
-10
| {{ $offlineSearchIndex := resources.Get "json/offline-search-index.json" | resources.ExecuteAsTemplate "offline-search-index.json" . }} | ||
| {{ $offlineSearchLink := $offlineSearchIndex.RelPermalink -}} | ||
| {{ if hugo.IsProduction -}} | ||
| {{/* Use `md5` as finger print hash function to shorten file name to avoid `file name too long` error. */}} | ||
| {{ $offlineSearchIndexFingerprint := $offlineSearchIndex | resources.Fingerprint "md5" }} | ||
| {{ $offlineSearchLink = $offlineSearchIndexFingerprint.RelPermalink -}} | ||
| {{ end -}} |
Collaborator
There was a problem hiding this comment.
This change reverts #691. Again, I don't know if this is by mistake or by design, but it seems to be happening a little too often IMHO.
I'm wondering if it is a process issue where folks aren't working from the latest version of docsy and simply cause updates to be lost (reverted) when they commit. It might be worth having a discussion about this, WDYT @LisaFC?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following error with Hugo 0.88.1 when offline search is enabled and the document contains
{{.