Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Signed |
|
CLAs look good, thanks! |
| set (PKGCONFIG_INSTALL_DIR) | ||
| else () | ||
| set (PKGCONFIG_INSTALL_DIR ${_glog_CMake_LIBDIR}/pkgconfig) | ||
| endif () |
There was a problem hiding this comment.
Please do not leave the conditions empty.
| Description: Google Log (glog) C++ logging framework | ||
| Version: @GLOG_VERSION@ | ||
| Libs: -L${libdir} -lglog | ||
| Cflags: -I${includedir} |
There was a problem hiding this comment.
The compile definitions seem to be missing.
| @@ -0,0 +1,10 @@ | |||
| prefix=@CMAKE_INSTALL_PREFIX@ | |||
There was a problem hiding this comment.
I would rename package.pc.in to libglog.pc.in.
|
Problem 1) Has this been merged? Any chance of that happening? Pull request and CLAs signed over 18 months ago. Checks completed over 14 months ago. Issue remained open in limbo since? This sort of neglect is a prime example favoring the complete removal of ALL Google's code from this and all future projects. Problem 2) A missing pkg-config file in MSYS2's MINGW libglog v0.3.5 package has caused failure to build 3rd party software. Not sure if this patch fixes it, or if v0.4.0 fixes the missing .pc file, or if it is related to some MSYS2/MINGW interaction. |
|
Superseded by #483. |
5 participants
Produce a libglog.pc file that is identical to the one autotools generates and installs.