This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Support pkg-config#483
Merged
sergiud merged 1 commit intogoogle:masterfrom Nov 1, 2019
loop0day:enhance
Merged
Conversation
sergiud
suggested changes
Nov 1, 2019
CMakeLists.txt
Outdated
| configure_file (src/glog/stl_logging.h.in glog/stl_logging.h @ONLY) | ||
| configure_file (src/glog/vlog_is_on.h.in glog/vlog_is_on.h @ONLY) | ||
| if (WITH_PKGCONFIG) | ||
| set(VERSION ${PROJECT_VERSION}) |
Contributor
There was a problem hiding this comment.
Please use the code style in CMakeLists.txt and add a space between the command the parenthesis.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve some codes to support pkg-config.