Repository.List: Add nebula-preview to receive visibility field#1780
Merged
gmlewis merged 1 commit intogoogle:masterfrom Jan 25, 2021
andygrunwald:support-visibility-in-repo-list
Merged
Repository.List: Add nebula-preview to receive visibility field#1780gmlewis merged 1 commit intogoogle:masterfrom andygrunwald:support-visibility-in-repo-list
gmlewis merged 1 commit intogoogle:masterfrom
andygrunwald:support-visibility-in-repo-list
Conversation
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1780 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 98 98
Lines 6387 6387
=======================================
Hits 6230 6230
Misses 85 85
Partials 72 72
Continue to review full report at Codecov.
|
gmlewis
approved these changes
Jan 23, 2021
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @andygrunwald !
LGTM.
Awaiting second LGTM before merging.
Collaborator
|
Thank you, @wesleimp ! |
This was referenced Feb 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What this PR does / why we need it:
When calling
Repositories.List(API Method: List repositories for the authenticated user), the fieldvisibilityis alwaysnil.The
visibilitywas introduced in a developer / API preview controlled by the media accept header.This PR enabled the API preview
nebula-previewforRepositories.List, to retrieve thevisibilityof a repository.Special notes for your reviewer:
None
Does this PR introduce a user-facing change?:
None
Additional documentation e.g., usage docs, etc.:
visibilityfield is available.