Apps.ListRepos/Apps.ListUserRepos: Add mercy-preview + nebula-preview headers#1806
Merged
gmlewis merged 1 commit intogoogle:masterfrom Mar 5, 2021
andygrunwald:support-visibility-in-repo-app-list
Merged
Apps.ListRepos/Apps.ListUserRepos: Add mercy-preview + nebula-preview headers#1806gmlewis merged 1 commit intogoogle:masterfrom andygrunwald:support-visibility-in-repo-app-list
gmlewis merged 1 commit intogoogle:masterfrom
andygrunwald:support-visibility-in-repo-app-list
Conversation
… headers * mercy-preview: For receiving repository topics * nebula-preview: For visibility information
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1806 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 100 100
Lines 6521 6525 +4
=======================================
+ Hits 6364 6368 +4
Misses 85 85
Partials 72 72
Continue to review full report at Codecov.
|
gmlewis
approved these changes
Feb 21, 2021
Collaborator
There was a problem hiding this comment.
Thank you, @andygrunwald !
I've gone through the GitHub v3 API docs and can't find any mention of the nebula-preview custom header... why is that one needed? EDIT: Ah! I see you already covered this in your description... awesome. Thank you!
Otherwise, LGTM.
Awaiting second LGTM before merging.
Collaborator
|
Never mind my last comment. 😂 See edit above. |
Contributor
Author
Collaborator
|
Thank you, @wesleimp ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What this PR does / why we need it:
When calling
Apps.ListReposorApps.ListUserRepos, the fieldvisibilityandtopicare alwaysnil.The reason: Missing headers for developers preview API.
Special notes for your reviewer:
This applies the same fix as in #1780
Does this PR introduce a user-facing change?:
None
Additional documentation e.g., usage docs, etc.: