Add example android app able to make GetEntry requests#2
Add example android app able to make GetEntry requests#2AMarcedone wants to merge 10 commits intogoogle:masterfrom
Conversation
exampleapp/BUILD
Outdated
| @@ -0,0 +1,13 @@ | |||
| android_binary( | |||
| name = "exampleapp", | |||
| srcs = glob(["src/main/java/com/google/keytransparency/exampleapp/*.java"]), | |||
There was a problem hiding this comment.
We prefer to not use glob in BUILD files if we can.
Would you mind breaking these files out into a list?
|
I hope this is not pedantic, but it would great if you could commit the library component as it's own PR? This PR is great, but it contains both the app and the library. |
| @@ -0,0 +1,3 @@ | |||
| -----BEGIN PUBLIC KEY----- | |||
There was a problem hiding this comment.
These can now be pulled directly from v1/domain/info for a simpler configuration
| @@ -0,0 +1,28 @@ | |||
| android_library( | |||
There was a problem hiding this comment.
Looks like this file could use a format pass with the buildifier formatter
go get github.com/bazelbuild/buildtools/buildifier
keytransparency/BUILD
Outdated
| outs = ["keytransparency_gobind.aar"], | ||
| tags=["local"], | ||
| local = 1, | ||
| cmd = "gomobile bind -target android -o $@ -javapkg com.google.keytransparency.gobind github.com/google/keytransparency/core/client/gobindClient github.com/google/keytransparency/core/client/kt github.com/google/keytransparency/core/crypto/commitments", |
There was a problem hiding this comment.
should these be listed as the sources?
There was a problem hiding this comment.
I think so (so that the library is rebuilt when they change), but they live in the $GOPATH directory which is not part of the workspace.
Also, these packages in turn depend on other go packages (like trillian), so I would have to list the whole GOPATH as source?
Also, we need to decide what to do with vendoring....
gdbelvin
left a comment
gdbelvin
left a comment
There was a problem hiding this comment.
This is such a great start.
Please pair this PR down to just be the java library.
|
I will move the android exampleapp part to a separate PR. |
AMarcedone
force-pushed
the
bazelProjectSetup
branch
from
2755a51 to
3b67c7e
Compare
AMarcedone
changed the title
|
The library is now in a separate PR #3. This is still a WIP, but it should build and run if anybody is curious to test.
|
AMarcedone
force-pushed
the
bazelProjectSetup
branch
from
3b67c7e to
a97965f
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Closed. The code was merged through a different PR #6 |
3 participants
Not ready for merge.
Responding to feedback from #1, this PR does not check in any IDE files and uses bazel instead of gradle to build.
Early feedback appreciated. Especially on project setup/directory structure etc.
To test, update the GOPATH and ANDROID_HOME in the .bazelrc file, then run
bazel mobile-install exampleapp.Depends on google/keytransparency#736 (which in turn depends on another trillian PR)
TODO: remove reference to my personal machine in the WORKSPACE file.