Skip to content
This repository was archived by the owner on Sep 10, 2022. It is now read-only.

Comments

Add the keytransparency android library#3

Closed
AMarcedone wants to merge 6 commits intogoogle:masterfrom
AMarcedone:bazelSetupKTLib
Closed

Add the keytransparency android library#3
AMarcedone wants to merge 6 commits intogoogle:masterfrom
AMarcedone:bazelSetupKTLib

Conversation

@AMarcedone
Copy link
Contributor

WIP.
Setup bazel WORKSPACE and BUILD files for a keytransparency library.
The library is a light wrapper around the keytransparency go code (compiled through gobind) and (at the moment) only allows to make GetEntry requests.
Depends on google/keytransparency#736

@@ -0,0 +1,84 @@
package com.google.keytransparency;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the client package into com.google.keytransparency.client

@@ -0,0 +1,6 @@
android_sdk_repository(
name = "androidsdk",
path = "/Users/antonio.marcedone/Library/Android/sdk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set to an environment variable and mention it in the README?

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@AMarcedone
Copy link
Contributor Author

Closed.

@AMarcedone AMarcedone closed this Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants