Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Comments

Don't timeout users entering OAuth info#1195

Merged
gdbelvin merged 3 commits intogoogle:masterfrom
gdbelvin:timeout
Feb 8, 2019
Merged

Don't timeout users entering OAuth info#1195
gdbelvin merged 3 commits intogoogle:masterfrom
gdbelvin:timeout

Conversation

@gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Feb 7, 2019

Note that this is an incomplete fix

Before

go run ./cmd/keytransparency-client/main.go post dazwilkin@google.com --client-secret=/Users/gbelvin/Downloads/client_secret_442418751519-0dgrd0631a9e0n1289g2ebp9evg6ln2m.apps.googleusercontent.com.json --insecure --data='dGVzdA==' --password=${PASSWORD} --kt-url=0.0.0.0:443 --verbose --logtostderr --timeout=10s
Go to the following link in your browser then type the authorization code:
Error: context deadline exceeded

After

go run ./cmd/keytransparency-client/main.go post dazwilkin@google.com --client-secret=/Users/gbelvin/Downloads/client_secret_442418751519-0dgrd0631a9e0n1289g2ebp9evg6ln2m.apps.googleusercontent.com.json --insecure --data='dGVzdA==' --password=${PASSWORD} --kt-url=0.0.0.0:443 --verbose --logtostderr
Go to the following link in your browser then type the authorization code:
xxxxxxxx
2019/02/07 19:39:08 ✓ Signed Map Head signature verified.
2019/02/07 19:39:08 ✓ Log inclusion proof verified.
I0207 19:39:08.291734   43214 client.go:145] Trusted root updated to TreeSize 1
2019/02/07 19:39:08 ✓ Log root updated.
2019/02/07 19:39:08 ✓ Commitment verified.
2019/02/07 19:39:08 ✓ VRF verified.
2019/02/07 19:39:08 ✓ map inclusion proof verified.
2019/02/07 19:39:08 Got current entry...
2019/02/07 19:39:08 Sending Update request...
2019/02/07 19:39:10 ✓ Signed Map Head signature verified.
2019/02/07 19:39:10 ✓ Log inclusion proof verified.
2019/02/07 19:39:12 ✓ Signed Map Head signature verified.
2019/02/07 19:39:12 ✓ Log inclusion proof verified.
2019/02/07 19:39:14 ✓ Signed Map Head signature verified.
2019/02/07 19:39:14 ✓ Log inclusion proof verified.
2019/02/07 19:39:16 ✓ Signed Map Head signature verified.
2019/02/07 19:39:16 ✓ Log inclusion proof verified.
2019/02/07 19:39:18 ✓ Signed Map Head signature verified.
2019/02/07 19:39:18 ✓ Log inclusion proof verified.
2019/02/07 19:39:20 ✓ Signed Map Head signature verified.
2019/02/07 19:39:20 ✓ Log inclusion proof verified.
Error: update failed: context deadline exceeded

@DazWilkin
Copy link
Contributor

Checking

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #1195 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1195      +/-   ##
==========================================
- Coverage   65.01%   64.86%   -0.15%     
==========================================
  Files          46       46              
  Lines        3336     3336              
==========================================
- Hits         2169     2164       -5     
- Misses        810      813       +3     
- Partials      357      359       +2
Impacted Files Coverage Δ
core/keyserver/revisions.go 63.92% <0%> (-1.9%) ⬇️
impl/sql/directory/storage.go 67.66% <0%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25eae20...0dc980f. Read the comment docs.

@gdbelvin gdbelvin requested a review from pav-kv February 8, 2019 12:21
@gdbelvin gdbelvin merged commit 5ac39fe into google:master Feb 8, 2019
@gdbelvin gdbelvin deleted the timeout branch February 8, 2019 12:28
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Feb 8, 2019
* master:
  Don't timeout users entering OAuth info (google#1195)
  Linter fixups (google#1197)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants