Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Comments

Linter fixups#1197

Merged
gdbelvin merged 8 commits intogoogle:masterfrom
gdbelvin:blacklist
Feb 8, 2019
Merged

Linter fixups#1197
gdbelvin merged 8 commits intogoogle:masterfrom
gdbelvin:blacklist

Conversation

@gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Feb 8, 2019

  • Bump linter version to 1.13.2
  • Add checks for improper imports
  • Trim exception list

gdbelvin and others added 3 commits February 8, 2019 12:04
…blacklist

* 'blacklist' of github.com:gdbelvin/keytransparency:
  Typo "hander" should be "handler" (google#1196)
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #1197 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1197      +/-   ##
==========================================
- Coverage   65.04%   65.01%   -0.03%     
==========================================
  Files          46       46              
  Lines        3336     3336              
==========================================
- Hits         2170     2169       -1     
  Misses        810      810              
- Partials      356      357       +1
Impacted Files Coverage Δ
core/crypto/tinkio/pem.go 72% <ø> (ø) ⬆️
core/crypto/tinkio/protofile.go 0% <ø> (ø) ⬆️
core/sequencer/trillian_client.go 59.18% <0%> (-4.09%) ⬇️
core/sequencer/server.go 72.89% <0%> (-1.87%) ⬇️
impl/sql/directory/storage.go 69.17% <0%> (+1.5%) ⬆️
core/keyserver/revisions.go 65.82% <0%> (+1.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5487dfb...6c06afe. Read the comment docs.

@gdbelvin gdbelvin merged commit 25eae20 into google:master Feb 8, 2019
@gdbelvin gdbelvin deleted the blacklist branch February 8, 2019 12:19
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Feb 8, 2019
* master:
  Don't timeout users entering OAuth info (google#1195)
  Linter fixups (google#1197)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants