This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
==========================================
+ Coverage 66.36% 66.49% +0.12%
==========================================
Files 54 54
Lines 4026 4026
==========================================
+ Hits 2672 2677 +5
+ Misses 961 958 -3
+ Partials 393 391 -2
Continue to review full report at Codecov.
|
NatalieDoduc
left a comment
NatalieDoduc
left a comment
There was a problem hiding this comment.
Thanks for clarifying bits of this PR - if you could add this offline context to the PR description, the collective memory would be most grateful :)
Not approving yet, because i'm unsure about the dependency chain implications.
golangcibot
reviewed
Jan 17, 2020
NatalieDoduc
approved these changes
Jan 17, 2020
gRPC now requires a handshake to occur grpc/grpc-go#2565 This does not play well with cmux by default, but there is a setting that cmux offers to complete the handshake correctly: https://github.com/soheilhy/cmux#limitations
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jan 20, 2020
Fixup from google#1435
Merged
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jan 27, 2020
This reverts commit ef79a0a. cmux cannot serve HTTP2 with Golang's http server.
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jan 28, 2020
This reverts commit ef79a0a. cmux cannot serve HTTP2 with Golang's http server.
gdbelvin
added a commit
that referenced
this pull request
Jan 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use cmux to differentiate between HTTP and GRPC connections.
cmux also (critically) supports serving gRPC over HTTP2 without TLS.