This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1442 +/- ##
==========================================
- Coverage 66.56% 66.31% -0.25%
==========================================
Files 54 54
Lines 4026 4026
==========================================
- Hits 2680 2670 -10
- Misses 955 962 +7
- Partials 391 394 +3
Continue to review full report at Codecov.
|
This reverts commit ef79a0a. cmux cannot serve HTTP2 with Golang's http server.
RJPercival
approved these changes
Jan 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prioritize HTTP2 over HTTP1
Revert #1435 and use
http.ServeHTTPrather than cmux.The GCE ingress load ballancer requires services to serve
an HTTP 200 OK at / on the same protocol that the server uses.
To support GRPC, this means using HTTP2 throuought.
HTTP2 also requires TLS, both by golang and GCE ingress.