Remove old key generation scripts#1447
Conversation
Replace with golang's `generate_cert.go`
Codecov Report
@@ Coverage Diff @@
## master #1447 +/- ##
=======================================
Coverage 67.83% 67.83%
=======================================
Files 54 54
Lines 4026 4026
=======================================
Hits 2731 2731
Misses 893 893
Partials 402 402Continue to review full report at Codecov.
|
NatalieDoduc
left a comment
NatalieDoduc
left a comment
There was a problem hiding this comment.
Is this idempotent in functionality?
|
It's the same functionality, but much more readable / maintainable. |
| ./scripts/gen_monitor_keys.sh -f | ||
| kubectl create secret generic kt-monitor --from-file=genfiles/monitor_sign-key.pem | ||
| kubectl create secret tls kt-tls --cert=genfiles/server.crt --key=genfiles/server.key | ||
| go run "$(go env GOROOT)/src/crypto/tls/generate_cert.go" --host localhost,127.0.0.1,:: |
There was a problem hiding this comment.
with go modules now, is there a way to express this without needing to set the GOROOT?
There was a problem hiding this comment.
go env GOROOT does not require the $GOROOT environment variable to be set.
GOROOT points to the go source tree, not the place where software is developed
`scripts/preare_server` was replaced with `$(go env GOROOT)/src/crypto/tls/generate_cert.go` in google#1447
`scripts/preare_server` was replaced with `$(go env GOROOT)/src/crypto/tls/generate_cert.go` in #1447
3 participants
Replace some very funky scripts with with golang's cleaner
generate_cert.go