This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Update README cert generation instructions#1550
Merged
gdbelvin merged 2 commits intogoogle:masterfrom May 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
==========================================
- Coverage 68.62% 68.59% -0.03%
==========================================
Files 57 57
Lines 4159 4159
==========================================
- Hits 2854 2853 -1
Misses 885 885
- Partials 420 421 +1
Continue to review full report at Codecov.
|
`scripts/preare_server` was replaced with `$(go env GOROOT)/src/crypto/tls/generate_cert.go` in google#1447
mhutchinson
reviewed
May 27, 2020
Comment on lines
+181
to
+183
| pushd genfiles | ||
| go run "$(go env GOROOT)/src/crypto/tls/generate_cert.go" --host localhost,127.0.0.1,:: | ||
| popd |
Contributor
There was a problem hiding this comment.
pushd and popd are not standard bash commands. I think they are standard for zsh, but I'd prefer to stick to standard built-ins for this.
Contributor
Author
There was a problem hiding this comment.
would cd dir && cd - be preferable?
btw -- I think pushd is part of bash.
https://linux.die.net/man/1/pushd
Contributor
|
LGTM. |
mhutchinson
approved these changes
May 27, 2020
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
May 28, 2020
…pan_mut * 'span_mut' of github.com:gdbelvin/keytransparency: Update README cert gen instructions (google#1550)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/preare_server.shwas replaced with$(go env GOROOT)/src/crypto/tls/generate_cert.goin #1447