This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Add a ProofNode protobuf to flesh out Merkle proofs#2
Closed
daniel-ziegler wants to merge 1 commit intogoogle:masterfrom
Closed
Add a ProofNode protobuf to flesh out Merkle proofs#2daniel-ziegler wants to merge 1 commit intogoogle:masterfrom
daniel-ziegler wants to merge 1 commit intogoogle:masterfrom
Conversation
proto/v2/e2ekeys.proto
Outdated
Contributor
There was a problem hiding this comment.
This makes sense as a data storage type. I'm not sure it makes sense to return to the user.
If you agree, create a separate proto file in the v2 directory for internal storage types.a
Contributor
|
First pull request, woot! |
Contributor
Author
|
I'm closing this since we're using prefix trees and not radix trees, so the API change is not necessary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reflects the storage design document. There will be one ProofNode returned for every node along the path in the Merkle radix tree. If these are hashed correctly, this will also solve the potential security problem I mentioned in the protobuf document.