This repository was archived by the owner on Oct 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 151
Add a ProofNode protobuf to flesh out Merkle proofs #2
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -212,12 +212,26 @@ message KeyPromise { | |
| Signature signature = 2; | ||
| } | ||
|
|
||
| // One node along a Merkle Tree authentication path. | ||
| message ProofNode { | ||
| // The coalesced substring at this node; all children start with this substring | ||
| int32 path_substring_length = 1; // In bits | ||
| bytes path_substring = 2; | ||
| // Only one left_child_hash or right_child_hash will be filled in; whichever | ||
| // one is along the path is left nil. | ||
| int64 left_child_epoch = 3; | ||
| bytes left_child_hash = 4; | ||
| int64 right_child_epoch = 5; | ||
| bytes right_child_hash = 6; | ||
|
||
| } | ||
|
|
||
| // A Proof provides an authentication path through the Merkel Tree that | ||
| // proves that an item is present in the tree. | ||
| message Proof { | ||
| // Neighbors is a list of all the adacent nodes along the path from the leaf | ||
| // object to the root. To save space, hashes for empty subtrees are omitted. | ||
| repeated bytes neighbors = 1; | ||
| // The list of nodes along the path. The client can verify the proof by | ||
| // hashing the nodes and iteratively filling in the missing hash in the next | ||
| // node until it reaches the root, where it can compare the root hash. | ||
| repeated ProofNode proof_nodes = 1; | ||
|
||
| // The root node in the Merkle tree. | ||
| SignedRoot epoch = 3; | ||
| // Output of an verifiable unpredictable function on user.meta.user_id. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense as a data storage type. I'm not sure it makes sense to return to the user.
If you agree, create a separate proto file in the v2 directory for internal storage types.a