Skip to content
This repository was archived by the owner on Jun 19, 2022. It is now read-only.

Update deps#1366

Closed
grantr wants to merge 2 commits into
google:masterfrom
grantr:update-deps
Closed

Update deps#1366
grantr wants to merge 2 commits into
google:masterfrom
grantr:update-deps

Conversation

@grantr
Copy link
Copy Markdown
Contributor

@grantr grantr commented Jun 30, 2020

Replaces #1360, which has a build failure due to a signature change in knative/eventing#3430. That build failure is fixed in the second commit here.

grantr added 2 commits June 30, 2020 16:11
./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jun 30, 2020
@nachocano
Copy link
Copy Markdown
Member

/lgtm

thanks @grantr !!!

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@grantr: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-build-tests 6bbe727 link /test pull-google-knative-gcp-build-tests
pull-google-knative-gcp-wi-tests 6bbe727 link /test pull-google-knative-gcp-wi-tests
pull-google-knative-gcp-integration-tests 6bbe727 link /test pull-google-knative-gcp-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-integration-tests 0/3
pull-google-knative-gcp-wi-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-google-knative-gcp-integration-tests:

github.com/google/knative-gcp/test/e2e.[build failed]

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@grantr: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Harwayne
Copy link
Copy Markdown
Contributor

/close

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@Harwayne: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved cla: yes (override cla status due to multiple authors bug) lgtm needs-rebase size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants