Skip to content

Eventing v1 e2e#3430

Merged
knative-prow-robot merged 9 commits into
knative:masterfrom
vaikas:eventing-v1-e2e
Jun 29, 2020
Merged

Eventing v1 e2e#3430
knative-prow-robot merged 9 commits into
knative:masterfrom
vaikas:eventing-v1-e2e

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Jun 28, 2020

Addresses #3411
Depends on #3360 (this is rebased off of that).

Proposed Changes

  • Add e2e tests that exercise broker/trigger v1/v1beta1 matrix

Release Note


Docs

@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 28, 2020
@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Jun 28, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Jun 28, 2020
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

matzew and others added 5 commits June 29, 2020 09:27
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@vaikas vaikas force-pushed the eventing-v1-e2e branch from 5298fc8 to 030bbc1 Compare June 29, 2020 17:00
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 29, 2020
@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 29, 2020

@googlebot I consent.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jun 29, 2020
@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 29, 2020

@googlebot all cool

@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-upgrade-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-upgrade-tests:

test/upgrade.TestContinuousEventsPropagationWithProber

@vaikas vaikas mentioned this pull request Jun 29, 2020
@chizhg
Copy link
Copy Markdown
Contributor

chizhg commented Jun 29, 2020

/uncc

@knative-prow-robot knative-prow-robot removed the request for review from chizhg June 29, 2020 20:47
@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 29, 2020

@googlebot I consent.

@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 29, 2020

@googlebot all cool

@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 29, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grantr grantr added cla: yes Indicates the PR's author has signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jun 29, 2020
@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@grantr
Copy link
Copy Markdown
Contributor

grantr commented Jun 29, 2020

@thisisnotapril CLA bot feedback: In this case the CLA bot check was stuck despite the presence of the cla: yes label. When I removed and re-added the label, the check became unstuck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants