Use CRD & Webhook v1 APIs by matzew · Pull Request #3360 · knative/eventing

matzew · 2020-06-22T09:09:49Z

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Proposed Changes

using v1 of the CRD type

Release Note

Our CustomResourceDefinitions now use apiextensions.k8s.io/v1 APIs

Docs

matzew · 2020-06-22T09:11:21Z

@dprotaso FYI I've started this on eventing

dprotaso · 2020-06-22T15:45:50Z

This change is required for conversion with v1 CRD APIs to work

knative/pkg#1433

matzew · 2020-06-22T18:53:14Z

@dprotaso thanks for the heads-up, I've updated the PR

matzew · 2020-06-22T18:55:36Z

-  - name: v1beta1
-    served: true
-    storage: true
+#      conversionReviewVersions: ["v1beta1", "v1alpha1"]


@vaikas you did disable the conversion, in this PR: #2595

I guess, we can now enable it ? 🤔

dprotaso · 2020-06-22T19:01:43Z

+  scope: Namespaced
+  conversion:
+    strategy: Webhook
+      conversionReviewVersions: ["v1beta1", "v1alpha1"]


These versions are the payload being set to the webhook - not the CRD version being reviewed

Suggested change

conversionReviewVersions: ["v1beta1", "v1alpha1"]

conversionReviewVersions: ["v1", "v1beta1"]

We need both v1 and v1beta1 because our min K8s version is 1.16.

The API imposes a restriction that we support conversionReview version that are available on K8s 1.15 & 1.16.

We can't drop v1beta1 it was the only available version in 1.15

matzew · 2020-06-23T19:14:09Z

/hold

aliok · 2020-06-24T07:59:54Z

-      # see issue: https://github.com/knative/serving/issues/912
-      x-kubernetes-preserve-unknown-fields: true
+  versions:
+  - &version


well, we do that already with everything on the verbs ;-)

but yeah 🙄

Nah, it is fine :) Just some YAML magic that I didn't know before :)
Actually gets rid of some dupes, which is nice

aliok · 2020-06-24T08:01:17Z

/retest

matzew · 2020-06-24T08:40:11Z

/hold

waiting for review from at least @dprotaso

matzew · 2020-06-24T10:08:49Z

/retest

anishj0shi · 2020-06-24T11:16:44Z

does this PR also updates the MutatingWebhookConfiguration and ValidatingWebhookConfiguration CRs to v1?

matzew · 2020-06-24T11:32:27Z

does this PR also updates the MutatingWebhookConfiguration and ValidatingWebhookConfiguration CRs to v1?

no - we should track bumping this as well, since its relevant for all of knative, at some point...

This PR is a follow up of the work that @dprotaso did on pkg and serving for CRDs. I'd vote for smaller PRs

anishj0shi · 2020-06-24T21:30:28Z

@matzew and @dprotaso I've raised a PR for updating eventing webhook: #3409

matzew · 2020-06-25T14:24:06Z

/test pull-knative-eventing-integration-tests

matzew · 2020-06-25T14:28:57Z

/test pull-knative-eventing-integration-tests

dprotaso · 2020-06-25T18:47:13Z

migrator job is failing

job.batch/storage-version-migration-v016 created
Waiting until all batch jobs in namespace knative-eventing run to completion.......................................................................................................................................................
ERROR: timeout waiting for jobs to complete
storage-version-migration-v016   1     <none>

I'd recommend dumping some logs in the test for more visibility

vaikas · 2020-06-26T18:35:33Z

+      clientConfig:
+        service:
+          name: eventing-webhook
+          namespace: knative-eventing


Looks like you can't drop the v1alpha1 for the brokers based on this from the failed upgrade tests:
for: "STDIN": CustomResourceDefinition.apiextensions.k8s.io "brokers.eventing.knative.dev" is invalid: status.storedVersions[0]: Invalid value: "v1alpha1": must appear in spec.versions
Error from server (Invalid): error when applying patch:
Or:
for: "STDIN": CustomResourceDefinition.apiextensions.k8s.io "pingsources.sources.knative.dev" is invalid: status.storedVersions[0]: Invalid value: "v1alpha1": must appear in spec.versions

Yeah this requires the storage migration job to be run before the upgrade

I do this after the upgrade in serving which is technically wrong (we've never dropped a version yet so we didn't catch it)

vaikas · 2020-06-28T19:59:49Z

/test pull-knative-eventing-upgrade-tests

matzew · 2020-06-29T11:47:57Z

/unhold

knative-test-reporter-robot · 2020-06-29T14:10:10Z

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-upgrade-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-upgrade-tests:

test/upgrade.TestContinuousEventsPropagationWithProber

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

dprotaso · 2020-06-29T15:27:33Z

lgtm

letting @vaikas do the heavy work

vaikas · 2020-06-29T15:40:35Z

/lgtm
/approve

knative-prow-robot · 2020-06-29T15:40:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [matzew,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2020

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 22, 2020

knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 22, 2020

knative-prow-robot requested review from liu-cong and slinkydeveloper June 22, 2020 09:10

matzew mentioned this pull request Jun 22, 2020

Use CRD & Webhook v1 APIs knative/pkg#1391

Merged

matzew force-pushed the CRD_v1 branch from e61b135 to ebe175e Compare June 22, 2020 18:52

matzew commented Jun 22, 2020

View reviewed changes

dprotaso reviewed Jun 22, 2020

View reviewed changes

matzew force-pushed the CRD_v1 branch 4 times, most recently from a94d511 to d012f2a Compare June 23, 2020 19:07

matzew changed the title ~~WIP: starting to use CRD_v1 APIs~~ Starting to use CRD_v1 APIs Jun 23, 2020

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2020

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2020

aliok reviewed Jun 24, 2020

View reviewed changes

matzew force-pushed the CRD_v1 branch from de04f85 to 449c56f Compare June 24, 2020 08:22

matzew changed the title ~~Starting to use CRD_v1 APIs~~ Use CRD & Webhook v1 APIs Jun 24, 2020

matzew force-pushed the CRD_v1 branch from c9f9d96 to 88ab8bd Compare June 24, 2020 08:53

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2020

matzew force-pushed the CRD_v1 branch from 2771df1 to 9fb6540 Compare June 25, 2020 13:38

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2020

matzew force-pushed the CRD_v1 branch from 10c8f4f to a51a81e Compare June 25, 2020 14:48

matzew changed the title ~~WIP: Use CRD & Webhook v1 APIs~~ Use CRD & Webhook v1 APIs Jun 25, 2020

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2020

matzew force-pushed the CRD_v1 branch from a51a81e to eb1f9bb Compare June 26, 2020 08:07

vaikas reviewed Jun 26, 2020

View reviewed changes

vaikas mentioned this pull request Jun 28, 2020

Eventing v1 e2e #3430

Merged

matzew force-pushed the CRD_v1 branch 2 times, most recently from ecb9ced to b69d793 Compare June 29, 2020 11:17

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2020

💫 switch to use CRD/webhook v1 APIs

3974f6c

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

matzew force-pushed the CRD_v1 branch from 00dbbe0 to 3974f6c Compare June 29, 2020 14:46

knative-prow-robot assigned vaikas Jun 29, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020

knative-prow-robot merged commit 4ce48fc into knative:master Jun 29, 2020

matzew mentioned this pull request Jun 29, 2020

Flow v1 crd #3418

Merged

aliok mentioned this pull request Sep 25, 2020

Add aliok to approvers #4118

Merged

pierDipi mentioned this pull request Oct 22, 2020

Use CRD v1 API for KafkaChannel, KafkaSource and KafkaBinding knative-extensions/eventing-kafka#132

Merged

	conversionReviewVersions: ["v1beta1", "v1alpha1"]
	conversionReviewVersions: ["v1", "v1beta1"]

Conversation

matzew commented Jun 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

matzew commented Jun 22, 2020

Uh oh!

dprotaso commented Jun 22, 2020

Uh oh!

matzew commented Jun 22, 2020

Uh oh!

matzew Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

dprotaso Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

dprotaso Jun 22, 2020

Choose a reason for hiding this comment

Uh oh!

matzew commented Jun 23, 2020

Uh oh!

aliok Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

matzew Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

aliok Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

aliok commented Jun 24, 2020

Uh oh!

matzew commented Jun 24, 2020

Uh oh!

matzew commented Jun 24, 2020

Uh oh!

anishj0shi commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matzew commented Jun 24, 2020

Uh oh!

anishj0shi commented Jun 24, 2020

Uh oh!

matzew commented Jun 25, 2020

Uh oh!

matzew commented Jun 25, 2020

Uh oh!

dprotaso commented Jun 25, 2020

Uh oh!

vaikas Jun 26, 2020

Choose a reason for hiding this comment

Uh oh!

dprotaso Jun 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vaikas commented Jun 28, 2020

Uh oh!

matzew commented Jun 29, 2020

Uh oh!

knative-test-reporter-robot commented Jun 29, 2020

Uh oh!

dprotaso commented Jun 29, 2020

Uh oh!

vaikas commented Jun 29, 2020

Uh oh!

knative-prow-robot commented Jun 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

matzew commented Jun 22, 2020 •

edited

Loading

anishj0shi commented Jun 24, 2020 •

edited

Loading

dprotaso Jun 26, 2020 •

edited

Loading