Use CRD & Webhook v1 APIs#1391
Conversation
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/XXL
| k8s.io/client-go \ | ||
| k8s.io/api \ | ||
| "admissionregistration:v1beta1 apps:v1 autoscaling:v1,v2beta1 batch:v1,v1beta1 core:v1 rbac:v1" \ | ||
| "admissionregistration:v1beta1,v1 apps:v1 autoscaling:v1,v2beta1 batch:v1,v1beta1 core:v1 rbac:v1" \ |
There was a problem hiding this comment.
do we still need the beta?
There was a problem hiding this comment.
No - but I don't want to break anyone consuming this package downstream so I left it
There was a problem hiding this comment.
We can drop with when the API version is dropped by K8s or it becomes a pain to maintain
There was a problem hiding this comment.
it's probably file. It's just more files :) If they're unused might not even be linked, so should not matter
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
Integration and upgrade tests passed in downstream knative/serving#8259 I was going to swap serving's CRDs to v1 but that can be a separate PR and doesn't need to block the webhook infra using v1 APIs |
|
/assign @mattmoor |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
started looking at eventing in knative/eventing#3360 |
6 participants
Addresses: knative/serving#6584