Skip to content

Use CRD & Webhook v1 APIs#8259

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
dprotaso:crd-v1
Jun 22, 2020
Merged

Use CRD & Webhook v1 APIs#8259
knative-prow-robot merged 2 commits into
knative:masterfrom
dprotaso:crd-v1

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Jun 8, 2020 •
edited
Loading

Proposed Changes

Release Note

Our CustomResourceDefinitions now use apiextensions.k8s.io/v1 APIs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 8, 2020
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 8, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2020
@dprotaso dprotaso mentioned this pull request Jun 8, 2020
Merged
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2020
@dprotaso dprotaso force-pushed the crd-v1 branch 4 times, most recently from 65eb1de to 038f5e7 Compare June 8, 2020 20:20
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2020
@matzew matzew mentioned this pull request Jun 19, 2020
Closed
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 19, 2020

/test pull-knative-serving-build-tests

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 19, 2020
@dprotaso dprotaso force-pushed the crd-v1 branch 2 times, most recently from dce5373 to 3988daa Compare June 21, 2020 20:17
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2020
@dprotaso dprotaso force-pushed the crd-v1 branch 3 times, most recently from 3ad9c87 to 2ad5c27 Compare June 22, 2020 13:21
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 22, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 22, 2020

weird - didn't pull the latest knative.dev/pkg

@vagababov
Copy link
Copy Markdown
Contributor

vagababov commented Jun 22, 2020

go mod ... @HEAD solves that for me usually

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 22, 2020 •
edited
Loading

yeah default go proxy has a 1 hour TTL

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 22, 2020

This is ready - need to rebase once #8386 merges

@dprotaso dprotaso changed the title [wip] Use CRD & Webhook v1 APIs Use CRD & Webhook v1 APIs Jun 22, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2020
@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 22, 2020

/assign @mattmoor

this also pulled in your genreconciler changes

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jun 22, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/reconciler/route.TestUpdateDomainConfigMap
pkg/reconciler/route.TestUpdateDomainConfigMap/example.com

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 22, 2020

/test pull-knative-serving-unit-tests

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Jun 22, 2020

flakey test captured here: #8056 (comment)

mattmoor
mattmoor reviewed Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 6c3eb04 into knative:master Jun 22, 2020
@dprotaso dprotaso deleted the crd-v1 branch June 23, 2020 00:02
matzew
matzew reviewed Jun 23, 2020
View reviewed changes
Comment thread config/core/resources/service.yaml
Comment on lines +57 to +60
- << : *version
name: v1beta1
- << : *version
name: v1
Copy link
Copy Markdown
Member

@matzew matzew Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dprotaso hey Dave, did I overlook this or, did you add it to the commit? 🤔

I have not that on eventing 😅

Copy link
Copy Markdown
Member Author

@dprotaso dprotaso Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just yaml hackery that merges v1alpha1 content into this yaml node and I override the name and storage properties

@yuchunyu97 yuchunyu97 mentioned this pull request Sep 11, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew left review comments

@andrew-su andrew-su Awaiting requested review from andrew-su

@vagababov vagababov Awaiting requested review from vagababov

+1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch to CRDs v1

7 participants

@dprotaso @vagababov @knative-test-reporter-robot @knative-prow-robot @matzew @mattmoor @googlebot