Enable webhook leader election.#8386
Conversation
knative-prow-robot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
mattmoor
force-pushed
the
allow-webhook-leaderelection
branch
from
b5b816e to
3655156
Compare
knative-prow-robot
added
size/XL
| min_replicas=$(kubectl get hpa activator -n "${SYSTEM_NAMESPACE}" -ojsonpath='{.spec.minReplicas}') | ||
| max_replicas=$(kubectl get hpa activator -n "${SYSTEM_NAMESPACE}" -ojsonpath='{.spec.maxReplicas}') |
There was a problem hiding this comment.
kubectl get hpa activator -n "${SYSTEM_NAMESPACE}" -ojsonpath='"minReplicas": {.spec.minReplicas} "maxReplicas": {.spec.maxReplicas}'will give you the innards directly
There was a problem hiding this comment.
I am just moving this 🤷
There was a problem hiding this comment.
yeah but why not improve things.
| add_trap "kubectl -n ${SYSTEM_NAMESPACE} patch configmap/config-autoscaler --type=merge --patch='{\"data\":{\"allow-zero-initial-scale\":\"false\"}}'" SIGKILL SIGTERM SIGQUIT | ||
|
|
||
| kubectl -n "${SYSTEM_NAMESPACE}" patch configmap/config-leader-election --type=merge \ | ||
| --patch='{"data":{"enabledComponents":"controller,hpaautoscaler,webhook", "buckets": 10}}' |
There was a problem hiding this comment.
I guess controller & hpaautoscaler currently don't support buckets, since it hasn't been merged, but do we want to enable that here before they do?
There was a problem hiding this comment.
I want to exercise the bucketing in the webhook, and it is harmless for the others until they switch to the new style of enabling LE.
|
/retest |
mattmoor
force-pushed
the
allow-webhook-leaderelection
branch
2 times, most recently
from
7a15f18 to
c168bfc
Compare
|
Need to rerun codegen after rebasing. I also noticed that the failing test is due to |
mattmoor
force-pushed
the
allow-webhook-leaderelection
branch
from
c168bfc to
d0a71fc
Compare
vagababov
left a comment
vagababov
left a comment
There was a problem hiding this comment.
/lgtm
/hold
if you wish to improve things ;-)
| min_replicas=$(kubectl get hpa activator -n "${SYSTEM_NAMESPACE}" -ojsonpath='{.spec.minReplicas}') | ||
| max_replicas=$(kubectl get hpa activator -n "${SYSTEM_NAMESPACE}" -ojsonpath='{.spec.maxReplicas}') |
There was a problem hiding this comment.
yeah but why not improve things.
knative-prow-robot
added
the
do-not-merge/hold
|
/hold cancel I'll send a smaller PR to follow up that simplifies the bash. |
knative-prow-robot
removed
the
do-not-merge/hold
This also directs e2e tests to enable this and use 10 buckets. This also changes the e2e test configuration so that all of our tests are run with leaderelection enabled. Fixes: knative#8139
|
/test pull-knative-serving-unit-tests |
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests: |
mattmoor
force-pushed
the
allow-webhook-leaderelection
branch
from
d0a71fc to
3ebd764
Compare
|
/lgtm |
6 participants
This also directs e2e tests to enable this and use 10 buckets.
Fixes: #8139