Skip to content

Simplify the HA e2e test setup#8401

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
mattmoor:hpa-setup
Jun 23, 2020
Merged

Simplify the HA e2e test setup#8401
knative-prow-robot merged 1 commit into
knative:masterfrom
mattmoor:hpa-setup

Conversation

@mattmoor
Copy link
Copy Markdown
Member

@mattmoor mattmoor commented Jun 22, 2020

Based on #8386 (and a comment on it).

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 22, 2020
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 22, 2020
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Jun 22, 2020

This pull request fixes 2 alerts when merging dd32c5b into ac2f58a - view on LGTM.com

fixed alerts:

  • 2 for Disabled TLS certificate check

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jun 22, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-autotls-tests 0/3
pull-knative-serving-integration-tests 0/3
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-integration-tests:

test/scale.TestScaleToN
test/conformance/api/v1.TestUpdateConfigurationMetadata
test/conformance/api/v1.TestContainerExitingMsg
test/conformance/api/v1.TestRouteAndConfigGenerateName
test/conformance/api/v1.TestTranslation
test/conformance/api/v1.TestRevisionTimeout
test/conformance/api/v1.TestServiceAccountValidation
test/conformance/api/v1.TestServiceBYOName

and 50 more.

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 22, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor mattmoor changed the title [WIP] Simplify the HA e2e test setup Simplify the HA e2e test setup Jun 22, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2020
vagababov
vagababov reviewed Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
vagababov
vagababov reviewed Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@knative-prow-robot knative-prow-robot merged commit 534569b into knative:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@tcnghia tcnghia Awaiting requested review from tcnghia

@yt3liu yt3liu Awaiting requested review from yt3liu

1 more reviewer

@vagababov vagababov vagababov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vagababov vagababov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mattmoor @knative-test-reporter-robot @knative-prow-robot @vagababov @googlebot