Skip to content

Use CRD v1 APIs#329

Closed
yuchunyu97 wants to merge 2 commits into
knative:masterfrom
yuchunyu97:patch-1
Closed

Use CRD v1 APIs#329
yuchunyu97 wants to merge 2 commits into
knative:masterfrom
yuchunyu97:patch-1

Conversation

@yuchunyu97
Copy link
Copy Markdown

@yuchunyu97 yuchunyu97 commented Sep 11, 2020

Upgrade apiextensions.k8s.io/v1 with knative/serving.

See: knative/serving#8259, knative/serving#6584 and knative/serving#6582.

TODO:

  • upgrade the knative/serving package

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 11, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuchunyu97
To complete the pull request process, please assign mattmoor
You can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
Copy link
Copy Markdown
Contributor

Welcome @yuchunyu97! It looks like this is your first PR to knative/caching 🎉

@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @yuchunyu97. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 11, 2020
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

@yuchunyu97: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuchunyu97 yuchunyu97 closed this Sep 30, 2020
@yuchunyu97 yuchunyu97 deleted the patch-1 branch September 30, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants