Skip to content

Return TypeMeta as part of the conversion response#1433

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
dprotaso:webhook-crd-v1
Jun 22, 2020
Merged

Return TypeMeta as part of the conversion response#1433
knative-prow-robot merged 1 commit into
knative:masterfrom
dprotaso:webhook-crd-v1

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Jun 22, 2020 •
edited
Loading

This is a requirement when adopting CRD v1 APIs

Addresses: knative/serving#6584

@dprotaso
Return TypeMeta as part of the conversion response
62aef92 
This is a requirement when adopting CRD v1 APIs
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 22, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 22, 2020
mattmoor
mattmoor reviewed Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 02c28cd into knative:master Jun 22, 2020
@dprotaso dprotaso deleted the webhook-crd-v1 branch June 22, 2020 15:33
@dprotaso dprotaso mentioned this pull request Jun 22, 2020
Merged
dprotaso added a commit to dprotaso/pkg that referenced this pull request Jun 25, 2020
@dprotaso
Return TypeMeta as part of the conversion response (knative#1433)
be8514d 
This is a requirement when adopting CRD v1 APIs
dprotaso added a commit to dprotaso/pkg that referenced this pull request Jun 25, 2020
@dprotaso
Return TypeMeta as part of the conversion response (knative#1433)
a454972 
This is a requirement when adopting CRD v1 APIs
knative-prow-robot pushed a commit that referenced this pull request Jun 25, 2020
@dprotaso
[release-0.15] Have the webhook responses return TypeMeta (#1449)
dfb81cf 
* Return TypeMeta as part of the conversion response (#1433)

This is a requirement when adopting CRD v1 APIs

* Return TypeMeta as part of the admission response (#1444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcnghia tcnghia Awaiting requested review from tcnghia

1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dprotaso @knative-prow-robot @mattmoor @googlebot