Skip to content

[release-0.15] Have the webhook responses return TypeMeta#1449

Merged
knative-prow-robot merged 2 commits into
knative:release-0.15from
dprotaso:release-0.15
Jun 25, 2020
Merged

[release-0.15] Have the webhook responses return TypeMeta#1449
knative-prow-robot merged 2 commits into
knative:release-0.15from
dprotaso:release-0.15

Conversation

@dprotaso
Copy link
Copy Markdown
Member

This is required for v1 APIs and it's blocking smooth upgrades from 0.15 to 0.16

knative/eventing#3409 (comment)

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 25, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020
@dprotaso dprotaso changed the title Have the webhook responses return TypeMeta [release-0.15] Have the webhook responses return TypeMeta Jun 25, 2020
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit dfb81cf into knative:release-0.15 Jun 25, 2020
@dprotaso dprotaso deleted the release-0.15 branch June 25, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants