Skip to content

Subscription v1alpha1<->v1beta1#2595

Merged
knative-prow-robot merged 6 commits into
knative:masterfrom
vaikas:subs-v1beta1-conversion
Feb 19, 2020
Merged

Subscription v1alpha1<->v1beta1#2595
knative-prow-robot merged 6 commits into
knative:masterfrom
vaikas:subs-v1beta1-conversion

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Feb 18, 2020

Fixes #

Proposed Changes

  • Add conversion and conversion webhook for Subscription v1alpha1 <-> v1beta1

Release Note

- 🎁 Add new feature
 Add support for Subscription v1alpha1 <-> v1beta1 conversions.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 18, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 18, 2020
@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Feb 18, 2020

/hold
for e2e tests.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Feb 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020
n3wscott
n3wscott reviewed Feb 18, 2020
View reviewed changes
Comment thread config/core/resources/subscription.yaml
- name: Age
type: date
JSONPath: .metadata.creationTimestamp
validation:
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry. 😐

Copy link
Copy Markdown
Contributor Author

@vaikas vaikas Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL :)

@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Feb 18, 2020
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Feb 19, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/messaging/v1alpha1/subscription_conversion.go Do not exist 93.3%
pkg/apis/messaging/v1beta1/subscription_conversion.go Do not exist 100.0%
pkg/reconciler/broker/trigger.go 88.1% 88.2% 0.1

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Feb 19, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2020
@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Feb 19, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2020
@knative-prow-robot knative-prow-robot merged commit 9a433f7 into knative:master Feb 19, 2020
@vaikas vaikas deleted the subs-v1beta1-conversion branch February 19, 2020 04:11
@dsimansk dsimansk mentioned this pull request Feb 28, 2020
Closed
@matzew matzew mentioned this pull request Jun 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Harwayne Harwayne Awaiting requested review from Harwayne

1 more reviewer

@n3wscott n3wscott n3wscott left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@n3wscott n3wscott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vaikas @knative-prow-robot @knative-metrics-robot @n3wscott @googlebot