Skip to content
This repository was archived by the owner on Jun 19, 2022. It is now read-only.

Pin knative/pkg and knative/test-infra to release-0.16#1373

Merged
knative-prow-robot merged 6 commits into
google:masterfrom
Harwayne:pin-pkg-16
Jul 7, 2020
Merged

Pin knative/pkg and knative/test-infra to release-0.16#1373
knative-prow-robot merged 6 commits into
google:masterfrom
Harwayne:pin-pkg-16

Conversation

@Harwayne
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne commented Jul 1, 2020 •
edited
Loading

Proposed Changes

  • Pin knative/pkg and knative/test-infra to release-0.16 in preparation for the release.

Release Note

NONE

Verified locally with:

go build ./...
go test ./...
go test -tags e2e ./... -run "^HopefullyNoTestMatchesThisRegex$"

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jul 1, 2020
@ericlem
Copy link
Copy Markdown
Contributor

ericlem commented Jul 1, 2020

/lgtm

@ericlem
Copy link
Copy Markdown
Contributor

ericlem commented Jul 1, 2020

/lgtm

@Harwayne
Update test method call to match the new API provided by knative/even…
aec16ae 
…ting.

For future reference, this can be built with:

go test -tags e2e ./... -run "^HopefullyNoTestMatchesThisRegex$"
@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Jul 1, 2020

For my own future reference, the following does not build the tests:

go build -tags e2e ./...

This command does:

go test -tags e2e ./... -run "^HopefullyNoTestMatchesThisRegex$"

So the overall set of commands to make sure everything compiles and works (minus running the e2e tests) seems to be:

go build ./...
go test ./...
go test -tags e2e ./... -run "^HopefullyNoTestMatchesThisRegex$"

@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Jul 1, 2020

/retest

3 similar comments
@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Jul 1, 2020

/retest

@grac3gao-zz
Copy link
Copy Markdown
Contributor

grac3gao-zz commented Jul 2, 2020

/retest

@Harwayne
Copy link
Copy Markdown
Contributor Author

Harwayne commented Jul 6, 2020

/retest

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jul 7, 2020

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-wi-tests pull-google-knative-gcp-wi-tests 1/3

Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-wi-tests

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jul 7, 2020

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-google-knative-gcp-integration-tests:

github.com/google/knative-gcp/test/e2e.TestChannelTracing/Channel-messaging.cloud.google.com/v1alpha1

@nachocano
Copy link
Copy Markdown
Member

nachocano commented Jul 7, 2020

/retest
/lgtm

@chizhg
Copy link
Copy Markdown
Member

chizhg commented Jul 7, 2020

/retest

@grac3gao-zz
Copy link
Copy Markdown
Contributor

grac3gao-zz commented Jul 7, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 3707bd3 into google:master Jul 7, 2020
@Harwayne Harwayne deleted the pin-pkg-16 branch July 7, 2020 17:24
@nachocano nachocano mentioned this pull request Jul 29, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericlem ericlem Awaiting requested review from ericlem

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@nachocano nachocano

@ericlem ericlem

Labels

approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Harwayne @knative-prow-robot @ericlem @grac3gao-zz @knative-test-reporter-robot @nachocano @chizhg @googlebot