Removed hardcoded zipkin config#3441
Merged
Merged
Conversation
knative-prow-robot
added
size/L
knative-prow-robot
added
the
area/test-and-release
mattmoor
reviewed
Jun 30, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
matzew
reviewed
Jun 30, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Harwayne
added a commit
to Harwayne/knative-gcp
that referenced
this pull request
Jul 6, 2020
knative-prow-robot
pushed a commit
to google/knative-gcp
that referenced
this pull request
Jul 7, 2020
* Pin knative/pkg and knative/test-infra to release-0.16. * hack/updage-deps.sh --upgrade * hack/update-codegen.sh * Update test method call to match the new API provided by knative/eventing. For future reference, this can be built with: go test -tags e2e ./... -run "^HopefullyNoTestMatchesThisRegex$" * Update knative-eventing's config-tracing, to match knative/eventing#3441. * Correct the path...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3304
Proposed Changes
K_TRACING_CONFIGto configure the zipkin endpointdebug: "true",backend: "zipkin"andsample-rate: "1.0", otherwise the test will fail without a reasonable explainationtest/config/config-tracing.yamland it's applied when eventing is installed on CI cluster